Use find instead of find by id #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some custom routes created using the param[:id] but the Rails routes use the param[:budget_id] by default, so the same controller could be asked for different param keys.
This method will raise an exception if resource is not found when trying to call score_action on nil. Prefer to raise a 404 HTML NotFound error instead.
Make it easier to find by slug or id for sluggable models. Will return nil if resource is not found.
Make it easier to find by slug or id for sluggable models. It will raise a 404 HTML Not found error if the resource is not found.
houndci-bot
reviewed
Jan 17, 2019
Better raise a 404 HTML NotFound exception than any other unexpected error.
microweb10
force-pushed
the
use_find_instead_of_find_by_id
branch
from
1b6c1ee
to
1f4272b
Compare
microweb10
changed the title
voodoorai2000
approved these changes
Jan 23, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Use
find(id)instead offind_by(id: id). It's preferable to raise a 404 HTML error than any other unexpected/unknown Exception.Add the methods
find_by_slug_or_idandfind_by_slug_or_id!to the moduleSluggableto make it easier to add these methods other models.Does this PR need a Backport to CONSUL?
The following commits can be backported now:
The last commit 1b6c1ee, it would be nice to be able to
find_by_slugalso in CONSULBut, we will probably do it in a future PR, we will have to include at least this other PR #520