Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use find instead of find by #3580

Merged
merged 5 commits into from
Jun 5, 2019
Merged

Use find instead of find by #3580

merged 5 commits into from
Jun 5, 2019

Commits on Jun 3, 2019

  1. Hotfixing find the only budget for emails

    @bertocq @javierm
    bertocq authored and javierm committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    0d761dd View commit details
    Browse the repository at this point in the history

  2. Load budgets using slugs

    @voodoorai2000 @javierm
    voodoorai2000 authored and javierm committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    998b4d9 View commit details
    Browse the repository at this point in the history

  3. Use correct param in controller 

    There were some custom routes created using the param[:id] but the
Rails routes use the param[:budget_id] by default, so the same
controller could be asked for different param keys.
    @microweb10 @javierm
    microweb10 authored and javierm committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    4bd20ee View commit details
    Browse the repository at this point in the history

  4. Add method find_by_slug_or_id! to Sluggable module 

    Make it easier to find by slug or id for sluggable models. It will
raise a 404 HTML Not found error if the resource is not found.
    @microweb10 @javierm
    microweb10 authored and javierm committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    22076dd View commit details
    Browse the repository at this point in the history

  5. Use find instead of find_by_id 

    Better raise a 404 HTML NotFound exception than any other unexpected error.
    @microweb10 @javierm
    microweb10 authored and javierm committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    b122302 View commit details
    Browse the repository at this point in the history