Translate user generated content #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 13, 2019
voodoorai2000
force-pushed
the
translations
branch
from
4a45255
to
d9bd7d7
Compare
houndci-bot
reviewed
Mar 13, 2019
voodoorai2000
force-pushed
the
translations
branch
from
d9bd7d7
to
d0e0806
Compare
houndci-bot
reviewed
Mar 13, 2019
voodoorai2000
force-pushed
the
translations
branch
from
d0e0806
to
ad5bbde
Compare
houndci-bot
reviewed
Mar 21, 2019
houndci-bot
reviewed
Mar 25, 2019
houndci-bot
reviewed
Mar 27, 2019
houndci-bot
reviewed
Apr 3, 2019
houndci-bot
reviewed
Apr 4, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
warning: parser/current is loading parser/ruby26, which recognizes
warning: parser/current is loading parser/ruby26, which recognizes warning: 2.6.0-dev-compliant syntax, but you are running 2.6.1. warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri. 2 error(s) were found in ERB files Linting 1 files with 12 linters...expected attribute value after '=' (at >)
In file: app/views/proposals/_form.html.erb:21
In file: app/views/proposals/_form.html.erb:33
houndci-bot
reviewed
Apr 4, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
warning: parser/current is loading parser/ruby26, which recognizes
warning: parser/current is loading parser/ruby26, which recognizes warning: 2.6.0-dev-compliant syntax, but you are running 2.6.1. warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri. 2 error(s) were found in ERB files Linting 1 files with 12 linters...expected attribute value after '=' (at >)
In file: app/views/proposals/_form.html.erb:21
In file: app/views/proposals/_form.html.erb:33
houndci-bot
reviewed
Apr 10, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
warning: parser/current is loading parser/ruby26, which recognizes
warning: parser/current is loading parser/ruby26, which recognizes warning: 2.6.0-dev-compliant syntax, but you are running 2.6.1. warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri. 2 error(s) were found in ERB files Linting 1 files with 12 linters...expected attribute value after '=' (at >)
In file: app/views/proposals/_form.html.erb:21
In file: app/views/proposals/_form.html.erb:33
houndci-bot
reviewed
Apr 23, 2019
houndci-bot
reviewed
May 16, 2019
houndci-bot
reviewed
May 16, 2019
houndci-bot
reviewed
May 23, 2019
houndci-bot
reviewed
May 29, 2019
houndci-bot
reviewed
May 31, 2019
houndci-bot
reviewed
May 31, 2019
After extract translation interface partials from admin folder translations should be placed in general.yml file inside shared context.
This file was used at previous version of translation interface.
In order to not allow users to remove all persited translations from any resource. A few exceptions were added: * Does not apply to globalizable models without translatable attributes required * Make a copy of main model error on current translations to be more realistic
Now we take into consideration locales persisted but marked for destruction to complete some logic and to be able to show best translations on different situations.
Only when present
When a translation not exists yet we can mark them all for destruction by default. They already should be initialized correctly from database or via nested attributes.
…nagment logic During any translatable resource edit, if you remove all translations you will be redirected to same form with errors showing you one of persisted but marked to destroy translations, without this patch _destroy field value wil be true and you will no able to persist without re-addding the same language through translation interface.
Responsive translation interface
…ations Block translatable resource updates with no translations
voodoorai2000
force-pushed
the
translations
branch
2 times, most recently
from
3dd1b7a
to
7a00590
Compare
voodoorai2000
force-pushed
the
translations
branch
from
a7475f1
to
7a00590
Compare
|
Thanks @Senen, @taitus, @agileontheweb awesome work! 👏 |
This was referenced Oct 18, 2019
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Translate user generated content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Make all user generated content translatable.