Improve remote translations #3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 10, 2020
taitus
force-pushed
the
improve-remote-translations
branch
from
d6b751c
to
36b70c3
Compare
houndci-bot
reviewed
Feb 10, 2020
taitus
force-pushed
the
improve-remote-translations
branch
2 times, most recently
from
2942caf
to
910cad8
Compare
taitus
force-pushed
the
improve-remote-translations
branch
2 times, most recently
from
3365836
to
2b99a00
Compare
javierm
reviewed
Feb 25, 2020
app/models/remote_translation.rb
Outdated
|
|
||
| def already_translated_resource | ||
| if remote_translatable&.translations&.where(locale: locale).present? | ||
| errors.add(:locale, I18n.t("remote_translations.already_translated_resource")) |
There was a problem hiding this comment.
How about errors.add(:locale, :already_translated)? We could then configure it like we configure other translation messages, adding translations to activerecord.yml. I think the translation key would be something like activerecord.errors.models.remote_translation.attributes.locale.already_translated.
There was a problem hiding this comment.
Solved in the commit: cdb2937
javierm
reviewed
Feb 25, 2020
taitus
force-pushed
the
improve-remote-translations
branch
2 times, most recently
from
a747c92
to
bdbc924
Compare
houndci-bot
reviewed
Feb 26, 2020
taitus
force-pushed
the
improve-remote-translations
branch
from
bdbc924
to
6584eb1
Compare
- Do not display remote translations button when API key is not configured
taitus
force-pushed
the
improve-remote-translations
branch
from
6584eb1
to
2d56653
Compare
javierm
reviewed
Feb 26, 2020
| it "When defined in current locale should not detect remote_translations" do | ||
| proposal = create(:proposal) | ||
| comment = create(:comment, commentable: proposal) | ||
|
|
||
| expect(detect_remote_translations([proposal, comment])).to eq [] | ||
| end | ||
|
|
||
| it "When resource class has not translates should not detect remote_translations" do |
There was a problem hiding this comment.
"has not translates" seems to be a typo 🤔. How about "is not translatable"?
taitus
force-pushed
the
improve-remote-translations
branch
from
aa50512
to
807a55d
Compare
- Validate that locale is a valid locale for RemoteTranslation Client. - RemoteTranslation can only be created for resources that do not have the requested language translated
Legislation::Proposal is not Globalize model but use CommentableActions and try detect remote translations. Add new condition to discard Non Globalize models. This fix is necessary since the following commit was included: c1f3a4a.
taitus
force-pushed
the
improve-remote-translations
branch
from
807a55d
to
c5c771f
Compare
javierm
approved these changes
Feb 26, 2020
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…e-translations Improve remote translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related PR's:
Objectives
Visual Changes
None
Notes
None