Check remote translations locales at runtime #3992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were evaluating its value when the server starts. On production enviroments, that could mean weeks or months before the available locales are checked again, and so it would be possible to use a list which is no longer in sync with the list provided by microsoft.
The method `available_locales` in `RemoteTranslations::Microsoft::AvailableLocales` needs to execute a request to an external server in order to work, meaning it will fail if the machine its executed on doesn't have an internet connection. So we're stubbing the method in the tests using it.
houndci-bot
reviewed
Apr 28, 2020
| @@ -4,7 +4,7 @@ class RemoteTranslation < ApplicationRecord | |||
| validates :remote_translatable_id, presence: true | |||
| validates :remote_translatable_type, presence: true | |||
| validates :locale, presence: true | |||
| validates :locale, inclusion: { in: RemoteTranslations::Microsoft::AvailableLocales.available_locales } | |||
| validates :locale, inclusion: { in: ->(_) { RemoteTranslations::Microsoft::AvailableLocales.available_locales }} | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [114/110] (https://rubystyle.guide#80-character-limits)
taitus
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives