Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enahnacement] Have link button timeout be configurable #1210

Closed
tjedmunds opened this issue May 17, 2020 · 1 comment · Fixed by #1266
Closed

[Enahnacement] Have link button timeout be configurable #1210

tjedmunds opened this issue May 17, 2020 · 1 comment · Fixed by #1266
Labels
enhancement
Milestone
5..4.0

Comments

@tjedmunds
Copy link

I am running RC1 now for a few weeks and no real issues. Great solution! Discovery also works once I opened ports 50000 and 1900 for UPNP in my firewall.

I just wondered why the Link button only works for 30 seconds when Alexa requires a full 45 seconds to run discovery. I changed ha-bridge to 60 seconds thinking it would make it easier to Link and it would be great if this was built-in or even configurable. Wouldn't it be better to run Link for the entire time of discovery to avoid timing issues?

I was also running the java11 version before this RC so I compiled from source since I didn't see a java11 build this time around. Perhaps that isn't necessary anymore?
@bwssytems
Copy link
Owner

I agree, we can have the timeout as a variable in the control page and increase the default.

@bwssytems bwssytems added this to the 5.3.1 milestone Dec 8, 2020
@bwssytems bwssytems changed the title Enhancement Idea [Enahnacement] Have link button timeout be configurable Dec 8, 2020
This was referenced Dec 8, 2020
Closed
Merged
bwssytems added a commit that referenced this issue Dec 14, 2020
@bwssytems
Merge pull request #1266 from bwssytems/dev_branch_5.3.x
b3f2c25 
Dev branch 5.3.x to create v5.4.0

#1044 Alexa app, error "Device doesn't support requested value" bug question
#1118 Device status update in Alexa App is not working correctly for ha-bridge devices bug duplicate question
#1126 Can't get XY ColorData into URL enhancement question
#1127 Can't get separate hue, saturation and brightness enhancement question
#1128 Wrong color calucation in HS mode bug question
#1131 Changing color temperatur is not working correctly bug question
#1132 Conversion from CIE to RGB incorrect bug question
#1139 Device ID creation fails bug question
#1150 Home Assistant gets null exception during initialization bug question
#1170 Alexa not sending the correct color codes duplicate
#1171 Please add option: If bright request present with on, only send dim enhancement
#1184 Alexa will not discover HABridge question
#1191 When "Use UPNP Address Interface Only" is selected, echo cannot find ha-bridge bug
#1210 [Enahnacement] Have link button timeout be configurable enhancement
#1215 Alexa unable to discover recently added devices to ha-bridge duplicate question
#1227 Feature request: ${intensity.previous} value passing control enhancement
#1239 HA-Bridge has suddenly given up itself - Exception in thread "main" java.lang.NullPointerException bug question
#1243 Alexa device discovery now broke question
#1253 HABridge hue ColorDecode 0 0 0 bug question
#1256 Homeassistant devices not appearing bug question
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
5..4.0
Development

Successfully merging a pull request may close this issue.

Dev branch 5.3.x bwssytems/ha-bridge
2 participants
@bwssytems @tjedmunds