Device ID creation fails

[sub0ne]

Let's say you have created three devices with the IDs 100, 101 and 102. After restarting ha-bridge the DeviceRepository loads the device list and sets the assigns the highest ID to the variable 'nextID'. Now you add a new device in ha-bridge and the device 102 will be overwritten during save since nextID is first used and then incremented.

_loadResository():

for (int i = 0; i < list.length; i++) {
	if (list[i].getColorUrl() == null || list[i].getColorUrl().isEmpty())
		list[i].setDeviceState(DeviceState.createDeviceState(false));
	else
		list[i].setDeviceState(DeviceState.createDeviceState(true));
	put(list[i].getId(), list[i]);
	if (Integer.decode(list[i].getId()) > nextId) {
		nextId = Integer.decode(list[i].getId());
	}
}

and in save():

descriptors[i].setId(String.valueOf(nextId));
nextId++;

Solution proposal:

_loadResository():

for (int i = 0; i < list.length; i++) {
	if (list[i].getColorUrl() == null || list[i].getColorUrl().isEmpty())
		list[i].setDeviceState(DeviceState.createDeviceState(false));
	else
		list[i].setDeviceState(DeviceState.createDeviceState(true));
	put(list[i].getId(), list[i]);
	if (Integer.decode(list[i].getId()) >= nextId) {
		nextId = Integer.decode(list[i].getId()) + 1;
	}
}

gonna fix this in my branch https://github.com/sub0ne/ha-bridge

[bwssytems]

Hmmm, thought I fixed that before as it was an issue prior. Will take a look

[bwssytems]

Well, it needs to be updated to do something.... But, I need to make sure it works with a sparse array. The changes I made were to be able to account for gaps in the IDs. Guess it was not enough.

[bwssytems]

The solution is:

for (int i = 0; i < list.length; i++) {
	if (list[i].getColorUrl() == null || list[i].getColorUrl().isEmpty())
		list[i].setDeviceState(DeviceState.createDeviceState(false));
	else
		list[i].setDeviceState(DeviceState.createDeviceState(true));
	put(list[i].getId(), list[i]);
	if (Integer.decode(list[i].getId()) >= nextId) {
		nextId = Integer.decode(list[i].getId()) ;
	}
}

nextId = nextId + 1;

Have to wait until all devices are loaded to get the highest value.

[SvenXP]

Hi, not sure if it belongs here but seems related:

If i want to add a new device via "edit/copy" and then "add bridge device" it overwrites my existing device with id=100. so i can not add any new devices cause it just overwrites the last one.

Also i have no idea why i have id 100 cause i do not have that many devices and the one before is 41.

Update: just changed the last entry manually from 100 to 42. Then added a new device and it was set again to 100?!? Any ideas?

[bwssytems]

This is a bug that has not been released yet....

[bwssytems]

Fixed in RC3