Update brian2 submodule to last version using nosetest #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisalevi
force-pushed
the
update-brian2-submodule
branch
4 times, most recently
from
15472ce
to
06f1d94
Compare
Two changes from future brian2 commits: `_namespace` variables in some user functions and an added monitor test. Both will have to be removed once brian2 is updated.
This is the last brian2 version using nosetest before switching to pytest.
Instance attributes were declared as class attributes. Also removes two unused attributes.
See PR brian-team/brian2#1038 This change had been committed and reverted previously (824624) due to wrong brian2 version. Now brian2 is updated and the commit is reapplied.
The test file `brian2.tests.test_cpp_standalone` has only CPP Standalone only tests which were not run in the Brian2CUDA test suite. Some of these tests are not passing and need separate debugging.
Brian2 has only `cpp-standalone` only tests. I just copied them to be `cuda-standalon` only tests for now. But should probably just make the brian2 tests `standalone-compatible` instead? See comment in #183
denisalevi
force-pushed
the
update-brian2-submodule
branch
from
06f1d94
to
9b8af3c
Compare
Add support for deleting standalone code / results, see brian-team/brian2#1104
Brian2 change, see PR brian-team/brian2#1069
Brian2 tests is marked as `codegen-independent`. We now have a CUDA version. Should probably instead be `standalone-compatible` in brian2 instead, see #183.
Fix run regularly between runs after brian2 change, see brian-team/brian2#1069
We initialized the entire spikespace with `-1`, including the last array item, which is the counter variable. That one is now initialized to 0.
After brian2 change in PR brian-team/brian2#1042, the template has access to all variables in units of dt, which makes the template much easier.
Adds tests from TODO list in PR #194: - Tests from brian2's test_spikegenertor.py which where not 'standalone-compatible' - Test for spikegenerator eventspaces for homog. / heterog. delays - Test for spikegenerator on a different clock (currently not passing)
Because brian2 did that too 😀 brian-team/brian2@cb77dd
Fixes #50. Issue was the same as in PR brian-team/brian2#1119. We need to update the monitor's `N` variable on CUDA side and we need to update the device variable since it is copied to the host variable in `write_arrays()`. And we need to use `WRITES_TO_READ_ONLY_VARIABLES`, otherwise `N` will be cached in brian2 and not loaded after simulation.
RNG by precalculating needed number of random numbers is implemented but returning the correct random numbers when calling `poisson` is not implemented yet
Not tested. Missing: different lambda across codeobject
This commit mostly cleans up the random number generation. That means, changing variable names, restructuring variable types etc. and adding code documentation.
There was a bug due to functions being used before definition or declaration
Fails until #201 is fixed
Fix monitor indexing issues
This simplifies the makefile and makes it more similar to the C++ Standalone makefile
And make the compiler flags generated by `distutils.ccompiler` (used by C++ Standalone) compatible with CUDA compilation
…iler-kwds Support external header files, C++ compiler preferences and compiler keywords Parts are based on brian-team/brian2#1047
Implement poisson function and refactor RNG in device.py Following brian-team/brian2#1111
denisalevi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #200
There will be multiple PRs to merge specific updates into this branch (e.g. PR #209), this is to keep an overview of the changes in the separate PRs.
This PR will be merged once everything is updated for a specific brian2 version (see update steps in #200).
EDIT 08.08.2021
This PR merges the following PRs into master: