Fix spikegenerator.cu template #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug in periodicity (see #48) and makes sure the kernel works with multiple spikespaces due to homogeneous delays. See comments in template for potential optimizations.
denisalevi
added a commit
that referenced
this pull request
Aug 4, 2021
Adds tests from TODO list in PR #194: - Tests from brian2's test_spikegenertor.py which where not 'standalone-compatible' - Test for spikegenerator eventspaces for homog. / heterog. delays - Test for spikegenerator on a different clock (currently not passing)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in periodicity (see #48) and and implement correct spikespace usage when having homogeneous delays.
Tests are running.
The spikegenerator template could be further optimized, but I am leaving this for another time (see #193).
Additional TODOs:
brian2/tests/test_spikegeneratorwhich is not marked asstandalone-compatible. Implement that forcuda_standalone.Synapsesobject with homogeneous and heterogeneous delays. I didn't test at all if the spikespaces work correctly.EDIT 7.2021: TODOs implemented in PR #223