Fix monitor indexing issues #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f62749c
to
15f97ef
Compare
15f97ef
to
f7d3b42
Compare
Fixes #50. Issue was the same as in PR brian-team/brian2#1119. We need to update the monitor's `N` variable on CUDA side and we need to update the device variable since it is copied to the host variable in `write_arrays()`. And we need to use `WRITES_TO_READ_ONLY_VARIABLES`, otherwise `N` will be cached in brian2 and not loaded after simulation.
f7d3b42
to
056cba7
Compare
Fails until #201 is fixed
056cba7
to
b8fcb0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #50 and our equivalent of brian-team/brian2#1119.
I opened #201 as follow-up issue of #50 with unsolved comments (statemonitor only uses 1 block currently).
Tests are running.