Mambaforge migration #680
Draft
Mambaforge migration #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3394141161
💛 - Coveralls |
|
@jcohenadad I was able to update our Github Actions file to use mamba during the CI tests, and I tested a See here for full installation and test log: So I think there wouldn't be too much issue migrating to Mambaforge. There's different ways of installating it, however I think my preferred way to document it for users is to suggest installation through conda , instead of forcing them to use MiniForge like is being done in Shimming Toolbox here shimming-toolbox/shimming-toolbox#403. This is because they have an automated installation script to handle their environment (eg where they install miniforge automatically), whereas we don't and some of our users might not know how to manually manage both a prior Anaconda/Miniconda installation and a new Miniforge installation (i.e. they might complain they lost their old conda envs). Essentially, we would just need to add the instruction under "Existing conda install" described here, https://mamba.readthedocs.io/en/latest/installation.html, and then make them install the ADS venv with |
mathieuboudreau
added
the
installation
11 tasks
|
@mathieuboudreau not sure why I never reviewed this, sorry about that. I like this PR a lot and would like to revive it. We should merge this during/after the nnunet migration #800. Maybe we'll need a new PR because this one is pretty old. I had to re-install the venv to test new dependencies and conda was excruciatingly slow. mamba is faster and IIUC it can be used as a direct replacement. |
I agree - and it's (conda) been quite excruciatingly slow for me too lately. This PR wasn't ready for review, we need to write up instructions for the users in the documentation, note how in one of my prior comments I thought it may be wiser to first ask the users to install miniconda, and install mambaforge using that instead of going the route SCT does (since they have a different installation procedure ) |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Linked issues
#677