Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix generation of NPM release package (#75, #78) #79

Merged

Conversation

aeworxet
Copy link
Collaborator

@aeworxet aeworxet commented Oct 19, 2022

This PR adds building of the TypeScript code (transpilation to JavaScript) during release process, which was not required before migration of the codebase to TS, and therefore did not exist.
Due to absence of this step, after migration to TS NPM package was released without lib directory, which made the package unusable for end users.

Besides adding the building step, this PR also modifies files array of the package.json to include in the package file API.md.

Fixes #75
Fixes #78

Souvikns
Souvikns previously approved these changes Oct 19, 2022
package.json Outdated Show resolved Hide resolved
@aeworxet
Copy link
Collaborator Author

Changed "lib/" to "/lib".

Implemented separation of concerns, as

"build": "tsc",
"generate:assets": "npm run docs && npm run generate:readme:toc",
"prepublishOnly": "npm run build && npm run generate:assets"

Modified files array to include API.md.

"files": [
  "API.md",
  ...
],

Souvikns
Souvikns previously approved these changes Oct 19, 2022
Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 looking good.

@aeworxet
Copy link
Collaborator Author

Now it's looking even better after returning everything back.

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@aeworxet
Copy link
Collaborator Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 1d816ca into asyncapi:master Oct 19, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aeworxet aeworxet deleted the fix-generation-of-npm-release-package branch October 19, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing release script to package.json last release is broken without lib dir
5 participants