last release is broken without lib dir

[derberg]

Last release is not usable. Package is published without code

👇🏼 is what we see after package installation

I think it might be because of https://github.com/asyncapi/bundler/blob/master/package.json#L37

I think it should say "/lib" and not lib/
I do not see any other reason why it is not really published to npm.

"main": "lib/index.js" entrypoint is correct. It's just that the index file do not exist in the package

[toukirkhan]

@derberg can I look into this?

[derberg]

@toukirkhan please go ahead

[derberg]

tip: you can test it locally, if your fix works by running npm publish --dry-run, if I remember the command correct 😄

if terminal will print only 👇🏼

npm notice === Tarball Contents === 
npm notice 11.4kB LICENSE     
npm notice 7.1kB  README.md   
npm notice 3.0kB  package.json
npm notice === Tarball Details === 

then it is not fixed.
it is fixed if index.js will be listed too

[toukirkhan]

alright @derberg working on this one!!

[toukirkhan]

@derberg am using npm publish --dry -run it only shows package.json in tarball contents, am I doing something wrong?

[derberg]

@toukirkhan can you show full log, please, and what modifications you already did

[toukirkhan]

yeah am attaching the screenshots @derberg

[toukirkhan]

I have changed "lib/" to "/lib"

[toukirkhan]

also it has shown the tarball contents you mentioned above once

[derberg]

strange you see only package.json

anyway, I forgot to tell you that you need to install bundler npm i and then run npm run build to actually generate lib dir first. Publish dry run do not show lib probably because you do not have it there on a local drive

[toukirkhan]

I have did the same steps

…

On Thu, 13 Oct, 2022, 5:47 pm Lukasz Gornicki, ***@***.***> wrote: strange you see only package.json anyway, I forgot to tell you that you need to install bundler npm i and then run npm run build to actually generate lib dir first. Publish dry run do not show lib probably because you do not have it there on a local drive — Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVGH3Q4VCI6BLDHS5DGXK5LWC74WLANCNFSM6AAAAAARD747PE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[derberg]

ok 🤔 , can you share, like drop the view of the directory from which you run npm publish?

[toukirkhan]

yeah sure

[toukirkhan]

@derberg okay I got it changed lib but it still does not show index.html

[derberg]

you mean index.js right?
can you show latest logs?

[toukirkhan]

@derberg yeah

[derberg]

I saw that in picture your terminal says that npm run build doesn't exist. This is weirt. Are you sure bundler is the directory where you cloned the project? can you print all files you have there ls is command in UNIX, not sure windows

[toukirkhan]

[toukirkhan]

I saw that in picture your terminal says that npm run build doesn't exist. This is weirt. Are you sure bundler is the directory where you cloned the project? can you print all files you have there ls is command in UNIX, not sure windows

yeah sure

[Souvikns]

I think best would be if @toukirkhan you can open a PR, and we can check it.

[toukirkhan]

[toukirkhan]

I think best would be if @toukirkhan you can open a PR, and we can check it.

it won't be a great idea because it does not resolves the issue

[toukirkhan]

@derberg i did npm run build

[derberg]

Ok, I think I know what the problem is

you do ls and other command runs from inside the node_modules where bundler is installed, and yes it shows that package is empty, which is wrong.

now please explain why in bundler directory you installed @asyncapi/bundler

what is exactly in bundler directory, main one, not bundler\none_modules\@asyncapi\bundler?

[derberg]

so if C:\Users\Lenovo\Desktop\bundler is a place where you cloned your fork

then you should do:

C:\Users\Lenovo\Desktop\bundler> npm i
C:\Users\Lenovo\Desktop\bundler> npm run build
C:\Users\Lenovo\Desktop\bundler> npm publish --dry-run

[toukirkhan]

Ok, I think I know what the problem is

you do ls and other command runs from inside the node_modules where bundler is installed, and yes it shows that package is empty, which is wrong.

now please explain why in bundler directory you installed @asyncapi/bundler

what is exactly in bundler directory, main one, not bundler\none_modules\@asyncapi\bundler?

bundler directory is a directory in my desktop inside which I have installed the bundler

[toukirkhan]

so if C:\Users\Lenovo\Desktop\bundler is a place where you cloned your fork

then you should do:

C:\Users\Lenovo\Desktop\bundler> npm i
C:\Users\Lenovo\Desktop\bundler> npm run build
C:\Users\Lenovo\Desktop\bundler> npm publish --dry-run

yeah finally I got this!!

[toukirkhan]

I have run the command inside the cloned bundler repo and made a dry run and it shows this

[toukirkhan]

now where should I make the changes?

[toukirkhan]

here is the directory

[derberg]

yup, perfect. from your logs it looks like it is the fix we expect. go ahead and open up a PR

[toukirkhan]

@derberg okay cool! am opnening it rn

[asyncapi-bot]

🎉 This issue has been resolved in version 0.3.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀