Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing release script to package.json #78

Closed
derberg opened this issue Oct 17, 2022 · 4 comments · Fixed by #79
Closed

Add missing release script to package.json #78

derberg opened this issue Oct 17, 2022 · 4 comments · Fixed by #79
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@derberg
Copy link
Member

derberg commented Oct 17, 2022

The package is still not properly released.
It is because after migration to TS we forgot that we need to make sure proper lib/index.js code is produced during the release. In other words in current release script we do not run npm run build

Fix is to add below script to package.json:
"prepublishOnly": "npm run build"

@derberg derberg added bug Something isn't working good first issue Good for newcomers hacktoberfest labels Oct 17, 2022
@derberg
Copy link
Member Author

derberg commented Oct 17, 2022

@toukirkhan hey, letting you know, in case you are still interested in helping here as part of hacktoberfest, and maybe beyond

@toukirkhan
Copy link
Contributor

@derberg sure I will try to solve this.

@KeneePatel
Copy link

So, Do I just need to add "prepublishOnly": "npm run build" in package.json and under the "scripts" section and make a pr ? @derberg

@derberg
Copy link
Member Author

derberg commented Oct 19, 2022

hey folks, @aeworxet just opened a PR as this is important fix that is affecting users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants