Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick 3.3.9 #9262

Closed
11 of 51 tasks
sarabala1979 opened this issue Jul 30, 2022 · 15 comments
Closed
11 of 51 tasks

Cherry-pick 3.3.9 #9262

sarabala1979 opened this issue Jul 30, 2022 · 15 comments
Labels
type/feature Feature request

Comments

@sarabala1979
Copy link
Member

sarabala1979 commented Jul 30, 2022 •
edited
Loading

@sarabala1979 sarabala1979 added the type/feature Feature request label Jul 30, 2022
@terrytangyuan
Copy link
Member

I propose to cherry pick the following commits related to security:

@terrytangyuan terrytangyuan mentioned this issue Aug 1, 2022
Merged
@sarabala1979
Copy link
Member Author

…ixes #9170. (#9213)

@sarabala1979
Copy link
Member Author

I propose to cherry pick the following commits related to security:

This fix contains other feature changes. We could cherry pick

@sarabala1979
Copy link
Member Author

I am busy with priority work. I will try to release before the end of this week.

@sarabala1979
Copy link
Member Author

@terrytangyuan Do you have bandwidth do cherry-pick?

@mcgrawia
Copy link
Contributor

mcgrawia commented Aug 2, 2022

Hi @terrytangyuan @sarabala1979, is this something I could help out with? If one of you can provide a quick write up of what needs to be done, happy to take a stab at it.

@terrytangyuan
Copy link
Member

terrytangyuan commented Aug 2, 2022 •
edited
Loading

Yes, I can try cherry-picking to release-3.3 branch.

Update: it's cherry-picked but CI is failing. Investigating https://github.com/argoproj/argo-workflows/runs/7634723040?check_suite_focus=true

@terrytangyuan
Copy link
Member

@mcgrawia @sarabala1979 #9235 has been cherry-picked and CI is passing in the release branch.

@terrytangyuan
Copy link
Member

terrytangyuan commented Aug 2, 2022 •
edited
Loading

I cherry-picked this one as well.

@mcgrawia
Copy link
Contributor

mcgrawia commented Aug 4, 2022

Hi @terrytangyuan, it looks like the changes are ready to go on the release branch. Is there anything else that needs to be done before the patch can be released?

@sarabala1979
Copy link
Member Author

@terrytangyuan Sorry I forgot to mention. Cherry-pick process is to cherry-pick all fixes (exclude new feature fixes or fixes in new code).
we will cherry-pick the issue and mark selected here.
Can you try to cherry-pick the above list of issues?

@terrytangyuan
Copy link
Member

Okay I thought you only needed help with the mentioned fixes. Unfortunately I am on vacation starting today. Would you be able to take it from here?

@mcgrawia
Copy link
Contributor

mcgrawia commented Aug 9, 2022

Hi @sarabala1979, I see some progress was made on cherry picking the commits to the release branch. Just offering again to see if there's anything I can do to get this over the finish line. The Critical level CVE was identified 26 days ago and we are about to break our 30 day patch SLAs with our customers if we cannot get this released asap. Please let me know, thanks

@sarabala1979
Copy link
Member Author

Release 3.3.9

@mcgrawia
Copy link
Contributor

Thank you so much @sarabala1979!!

This was referenced Aug 16, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@terrytangyuan @mcgrawia @sarabala1979