Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fork sub-process. Fixes #8680 #8906

Merged
merged 2 commits into from
Jun 10, 2022
Merged

fix: Fork sub-process. Fixes #8680 #8906

merged 2 commits into from
Jun 10, 2022

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jun 3, 2022

Signed-off-by: Alex Collins [email protected]

Fixes #8680

@alexec alexec marked this pull request as ready for review June 3, 2022 19:25
@alexec alexec enabled auto-merge (squash) June 3, 2022 19:25
@alexec alexec requested a review from sarabala1979 June 3, 2022 19:25
@alexec alexec changed the title fix: Fork sub-process. Fixes #8454 fix: Fork sub-process. Fixes #8680 Jun 3, 2022
@sarabala1979 sarabala1979 self-assigned this Jun 7, 2022
Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

@alexec alexec merged commit 416fce7 into argoproj:master Jun 10, 2022
@alexec alexec deleted the wait branch June 10, 2022 15:13
This was referenced Jun 20, 2022
@sarabala1979 sarabala1979 mentioned this pull request Jul 30, 2022
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OOM error not caught by the emissary executor forcing the workflow to hang in "Running" state
3 participants