Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact GC: SearchArtifact to return ArtifactSearchResults #8543

Closed
alexec opened this issue Apr 29, 2022 · 0 comments · Fixed by #8557
Closed

Artifact GC: SearchArtifact to return ArtifactSearchResults #8543

alexec opened this issue Apr 29, 2022 · 0 comments · Fixed by #8557
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc good first issue Good for newcomers type/feature Feature request
Milestone

Comments

@alexec
Copy link
Contributor

alexec commented Apr 29, 2022

Currently, this func returns Artifacts, but we need to know which node ID the artifact was from, we can't add that to Artifact, but we can introduce some new types:

type ArtifactSearchResults []ArtifactSearchResult

type ArtifactSearchResult struct {
Artifact
NodeID string
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc good first issue Good for newcomers type/feature Feature request
Projects
None yet
3 participants