Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArtifactGC should be on Artifact not Template #8556

Closed
alexec opened this issue Apr 30, 2022 · 0 comments · Fixed by #8581
Closed

ArtifactGC should be on Artifact not Template #8556

alexec opened this issue Apr 30, 2022 · 0 comments · Fixed by #8581
Assignees
@dpadhiar
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc type/bug
Milestone
2022 Q3

Comments

@alexec
Copy link
Contributor

alexec commented Apr 30, 2022 •
edited
Loading

If a template has >1 artifact, then we cannot set them with different policies. So this field needs to be moved from Template to Artifact
@alexec alexec added type/bug area/artifacts S3/GCP/OSS/Git/HDFS etc labels Apr 30, 2022
@alexec alexec changed the title Artifact GC: should be on Artifact not Template ArtifactGC should be on Artifact not Template May 2, 2022
@dpadhiar dpadhiar self-assigned this May 2, 2022
dpadhiar added a commit to dpadhiar/argo-workflows that referenced this issue May 2, 2022
@dpadhiar
feat: ArtifactGC moved from Template to Artifact. Fixes argoproj#8556
04e4e60 
Signed-off-by: Dillen Padhiar <[email protected]>
@dpadhiar dpadhiar mentioned this issue May 2, 2022
Merged
alexec pushed a commit that referenced this issue May 3, 2022
@dpadhiar
fix: ArtifactGC moved from Template to Artifact. Fixes #8556. (#8581)
ed351ff 
Signed-off-by: Dillen Padhiar <[email protected]>
alexec pushed a commit that referenced this issue May 3, 2022
@dpadhiar @alexec
fix: ArtifactGC moved from Template to Artifact. Fixes #8556. (#8581)
0f29a64 
Signed-off-by: Dillen Padhiar <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@sarabala1979 sarabala1979 added this to the 2022 Q3 milestone May 4, 2022
This was referenced Jun 20, 2022
Closed
Closed
@sarabala1979 sarabala1979 mentioned this issue Jul 30, 2022
Closed
51 tasks
@sarabala1979 sarabala1979 mentioned this issue Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpadhiar dpadhiar

Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc type/bug
Projects
None yet
Milestone
2022 Q3
Development

Successfully merging a pull request may close this issue.

fix: ArtifactGC moved from Template to Artifact. Fixes #8556. dpadhiar/argo-workflows
3 participants
@alexec @sarabala1979 @dpadhiar