Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken import when using Argo go client #4791

Closed
JPZ13 opened this issue Dec 22, 2020 · 9 comments · Fixed by #4810
Closed

Broken import when using Argo go client #4791

JPZ13 opened this issue Dec 22, 2020 · 9 comments · Fixed by #4810
Labels

Comments

@JPZ13
Copy link
Member

JPZ13 commented Dec 22, 2020

Summary

When building a service that invokes Argo using the go client, I frequently run into the gnostic openapiv2 error. Newer kube dependencies seem to have fixed this, but existing versions will not be fixed 😞.

I'd propose bumping the K8s dependencies to a newer version. I'm happy to own the issue and make the changes.

Diagnostics

Here are my relevant go dependencies in go.mod:

require (
	github.com/argoproj/argo v0.0.0-20200724211756-20d2ace3d534
	k8s.io/api v0.17.8
	k8s.io/apimachinery v0.17.8
	k8s.io/client-go v0.17.8
	k8s.io/kubectl v0.17.5
)

Note: I use the scheme package in kubectl to interact with secrets.

Here's the error I get when running a build:

cannot load github.com/googleapis/gnostic/OpenAPIv2: module github.com/googleapis/gnostic@latest found (v0.5.3), but does not contain package github.com/googleapis/gnostic/OpenAPIv2

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@JPZ13 JPZ13 added the type/bug label Dec 22, 2020
@alexec
Copy link
Contributor

alexec commented Dec 22, 2020

Will this be fixed by #4425 ?

@JPZ13
Copy link
Member Author

JPZ13 commented Dec 22, 2020

Yes. @NikeNano, would you mind if I started on #4425? I'm currently blocked by it

@NikeNano
Copy link
Contributor

Sure @JPZ13 go for it, feel free to take what ever you want from my rough first stab at it, #4426

@JPZ13
Copy link
Member Author

JPZ13 commented Dec 22, 2020

Thanks @NikeNano!

@JPZ13
Copy link
Member Author

JPZ13 commented Dec 28, 2020

@alexec @NikeNano What's the command to update the client set? I ran make codegen a couple times and didn't get an update. I should be ready to put up a PR once I get client-gen to run properly.

@NikeNano
Copy link
Contributor

NikeNano commented Dec 28, 2020

Great @JPZ13, I am not aware of anything else than make codegen

UPDATE: I think the client updates are actually handled here and thus you should use make clean

@JPZ13
Copy link
Member Author

JPZ13 commented Dec 28, 2020

You are the man @NikeNano. I had to run chmod +x on $GOPATH/pkg/mod/k8s.io/[email protected]/generate-groups.sh and then was able to generate the client set. Thanks for pointing that out! I'll get it all cleaned up and put out a PR.

@NikeNano
Copy link
Contributor

Let me know when you have an PR @JPZ13, look forward to see this merged.

@JPZ13
Copy link
Member Author

JPZ13 commented Dec 29, 2020

Will do! I'll tag you as a reviewer when I put up the PR @NikeNano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants