Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s.io/api, k8s.io/apimachinery and k8s.io/client-go #4425

Closed
NikeNano opened this issue Oct 31, 2020 · 6 comments
Closed

Update k8s.io/api, k8s.io/apimachinery and k8s.io/client-go #4425

NikeNano opened this issue Oct 31, 2020 · 6 comments
Labels
go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/feature Feature request
Milestone

Comments

@NikeNano
Copy link
Contributor

Summary

Update go dependencies to stay up to date.

Use Cases

I have had issues trying to updated the argo version for Kubeflow pipelines to argo 2.11(currently are on 2.7) and updating the underlying dependencies for argo would make the update simpler. I understand this might not be a good enough reason to update the dependencies for argo it self though.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@NikeNano NikeNano added the type/feature Feature request label Oct 31, 2020
@NikeNano
Copy link
Contributor Author

/assign

@liafizan
Copy link
Contributor

I have same issue. Trying to build a client using a github.com/argoproj/argo v0.0.0-20201019203908-5eebce9af440 which requires k8s libs to be >= v0.18.2 which added context passing feature but looks like we do not have that in Argo. I keep getting errors like:

# github.com/argoproj/argo/server/auth/sso
../../../../../pkg/mod/github.com/argoproj/[email protected]/server/auth/sso/sso.go:84:39: not enough arguments in call to secretsIf.Get
	have (string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
	want (context.Context, string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
../../../../../pkg/mod/github.com/argoproj/[email protected]/server/auth/sso/sso.go:97:35: not enough arguments in call to secretsIf.Get
	have (string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
	want (context.Context, string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
# github.com/argoproj/argo/util/unstructured
../../../../../pkg/mod/github.com/argoproj/[email protected]/util/unstructured/unstructured.go:33:63: not enough arguments in call to client.Resource(resource).Namespace(namespace).List
	have ("k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions)
	want (context.Context, "k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions)
../../../../../pkg/mod/github.com/argoproj/[email protected]/util/unstructured/unstructured.go:39:64: not enough arguments in call to client.Resource(resource).Namespace(namespace).Watch
	have ("k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions)
	want (context.Context, "k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions)
# github.com/argoproj/argo/pkg/client/clientset/versioned/typed/workflow/v1alpha1
../../../../../pkg/mod/github.com/argoproj/[email protected]/pkg/client/clientset/versioned/typed/workflow/v1alpha1/clusterworkflowtemplate.go:54:5: not enough arguments in call to c.client.Get().Resource("clusterworkflowtemplates").Name(name).VersionedParams(&options, scheme.ParameterCodec).Do
	have ()
	want (context.Context)
../../../../../pkg/mod/github.com/argoproj/[email protected]/pkg/client/clientset/versioned/typed/workflow/v1alpha1/clusterworkflowtemplate.go:70:5: not enough arguments in call to c.client.Get().Resource("clusterworkflowtemplates").VersionedParams(&opts, scheme.ParameterCodec).Timeout(timeout).Do

apiclient is sort of unusable due to this issue

@NikeNano
Copy link
Contributor Author

I have started the work here: #4426 @liafizan will continue to push work, feel free to help out if you like to :)

@alexec alexec added this to the v3.0 milestone Nov 2, 2020
@alexec alexec linked a pull request Dec 20, 2020 that will close this issue
6 tasks
@alexec
Copy link
Contributor

alexec commented Dec 20, 2020

@NikeNano @liafizan we'd like to include this in v3.0, targetted end of January. Would you like to drive it?

@NikeNano
Copy link
Contributor Author

NikeNano commented Dec 21, 2020

Sure @alexec I would be happy to help out to drive this effort. Will start to put some work in to it during the Christmas weekend and New Years to push it!

@alexec
Copy link
Contributor

alexec commented Dec 21, 2020

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants