update gnostic dependency #189
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @apelisse |
| @@ -244,8 +249,10 @@ func schema_test_integration_testdata_listtype_MapList(ref common.ReferenceCallb | |||
| "Field": { | |||
| VendorExtensible: spec.VendorExtensible{ | |||
| Extensions: spec.Extensions{ | |||
| "x-kubernetes-list-map-keys": "port", | |||
| "x-kubernetes-list-type": "map", | |||
| "x-kubernetes-list-map-keys": []interface{}{ | |||
There was a problem hiding this comment.
This is correct, but why did it change?
| @@ -325,6 +332,142 @@ func schema_test_integration_testdata_listtype_UntypedList(ref common.ReferenceC | |||
| } | |||
| } | |||
|
|
|||
| func schema_test_integration_testdata_maptype_AtomicMap(ref common.ReferenceCallback) common.OpenAPIDefinition { | |||
There was a problem hiding this comment.
Same for this? Did we forget to commit that before? I also remember that somewhere it says we shouldn't commit updates to this file, but that doesn't really make sense ...
There was a problem hiding this comment.
yes, it was stale on master... needs a presubmit check
There was a problem hiding this comment.
I'm pretty sure somewhere it says it shouldn't be committed, we could also remove that comment ...
There was a problem hiding this comment.
https://github.com/kubernetes/kube-openapi/blob/master/test/integration/README.md
After the golden spec is generated, please clean up the generated file pkg/generated/openapi_generated.go before you commit. It's an intermediate product that doesn't need to be updated in kube-openapi repository. The checked-in file is kept minimum to make sure that test/integration/builder compiles. Please run:
$ git checkout pkg/generated/openapi_generated.goto discard any local change.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Starts the chain of updates required to get k8s.io/kubernetes on the 0.4.1 release