-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync 1.5.x into main #8320
Closed
Closed
Sync 1.5.x into main #8320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rade-platform-with-module
… chore-error-requests-count
… chore-error-requests-count � Conflicts: � app/controllers/shared/api.php � composer.json
Chore:usage requests count on error
Sync with 1.5.x
…rations Add `default` to Collection Attributes in Migration
There seems to be a load balancer in front of www.google.com that has either a certificate issuer of "Google Trust Services LLC" or "Google Trust Services". This causes the test to fail intermittently. This PR updates the test to check for the substring "Google Trust Services" instead of the exact string "Google Trust Services LLC".
The execution is async so give the function a bit more time to execute.
Before this, the Create session API call would throw: > Invalid document structure: Missing required attribute "expire" This is because the `expire` attribute is required, but it was omitted from the document. This PR ensures the `expire` attribute is set when creating the session document.
The create session endpoint created a 6 character secret which is too short. This changes the secret to be 256 characters which is in line with the secret for `account.createEmailPasswordSession()`.
utopia-php/database version 0.50.0 includes a new skipValidation() function we can use to skip validation when making queries.
If there are more than 100 targets, the validation throws an error. This change skips the validation so no error is thrown.
Fix flaky certificate test
Fix flaky function test
Disable validation for subquery to prevent error
…ating-session Fix 'Missing required attribute "expire"' on `users.createSession()`
Bump console to version 4.3.14
increase longtext
Prepare 1.5.8 release
Update Expires header via cache shared api
Sync refactor-usage-sn into 1.5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist