Disable validation for subquery to prevent error #8297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
changed the title
abnegate
reviewed
Jun 21, 2024
stnguyen90
force-pushed
the
fix-subscribers
branch
from
f240c9d
to
c752c73
Compare
abnegate
reviewed
Jun 21, 2024
app/init.php
Outdated
| Query::equal('$internalId', $targetIds) | ||
| ]); | ||
| try { | ||
| $database->disableValidation(); |
There was a problem hiding this comment.
Let's use the new skip here
stnguyen90
force-pushed
the
fix-subscribers
branch
3 times, most recently
from
4b69b0e
to
a0c0e97
Compare
utopia-php/database version 0.50.0 includes a new skipValidation() function we can use to skip validation when making queries.
If there are more than 100 targets, the validation throws an error. This change skips the validation so no error is thrown.
stnguyen90
force-pushed
the
fix-subscribers
branch
from
a0c0e97
to
3a3a059
Compare
abnegate
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If there are more than 100 targets, the validation throws an error. This change skips the validation so no error is thrown.
Fixes #8299
Test Plan
Added new test case which should pass
Related PRs and Issues
Parent PR:
Checklist