Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default to Collection Attributes in Migration #8271

Merged

Conversation

ItzNotABug
Copy link
Contributor

@ItzNotABug ItzNotABug commented Jun 14, 2024

What does this PR do?

Adds the default to collection attributes during migration.

Test Plan

Manual.

  1. 1.4.13 -

    Screenshot 2024-06-14 at 3 49 33 PM
  2. Upgraded to a local 1.5.7 & ran docker exec appwrite migrate -

    Screenshot 2024-06-14 at 3 56 24 PM
  3. _metadata -

    Screenshot 2024-06-14 at 3 58 12 PM
  4. topics table with defaults -

    Screenshot 2024-06-14 at 4 02 02 PM

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@ItzNotABug ItzNotABug changed the title Add defaults to Collection Attributes in Migration Add default to Collection Attributes in Migration Jun 14, 2024
@ItzNotABug
Copy link
Contributor Author

The Database & Function tests seems to pass locally -

Screenshot 2024-06-14 at 4 57 06 PM
Screenshot 2024-06-14 at 5 05 12 PM
Screenshot 2024-06-14 at 5 00 10 PM

@stnguyen90 stnguyen90 linked an issue Jun 20, 2024 that may be closed by this pull request
2 tasks
@stnguyen90 stnguyen90 self-requested a review June 20, 2024 04:33
@stnguyen90 stnguyen90 changed the base branch from main to 1.5.x June 20, 2024 04:33
@stnguyen90 stnguyen90 linked an issue Jun 20, 2024 that may be closed by this pull request
2 tasks
@ItzNotABug
Copy link
Contributor Author

Not sure why the tests keep failing on Functions continuously.

I'll update the branch and run the tests locally for once and check.

I believe the time-out based test often fails on GitHub.

@stnguyen90 stnguyen90 merged commit ae3bcb2 into appwrite:1.5.x Jun 21, 2024
23 checks passed
@ItzNotABug ItzNotABug deleted the fix-7892-add-defaults-to-migrations branch June 26, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Topic Shows 0 Subscribers
2 participants