Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add publish test of PyPi cu100mkl #14637

Merged
merged 11 commits into from
Apr 18, 2019
Merged

Add publish test of PyPi cu100mkl #14637

merged 11 commits into from
Apr 18, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Apr 5, 2019

Description

Add PyPi cu100mkl CI test to avoid manual test when updating the dependencies

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  1. add PyPi cu100mkl test
  2. align scala naming convention with PyPi

Comments

@lanking520 @szha

@piyushghai
Copy link
Contributor

Thanks for your contributions @stu1130.
@mxnet-label-bot Add [CI, Test]

@stu1130 stu1130 changed the title [WIP] Add publish test of PyPi cu100mkl [WIP] Add publish test of PyPi/Maven cu100mkl Apr 8, 2019
@stu1130 stu1130 changed the title [WIP] Add publish test of PyPi/Maven cu100mkl [WIP] Add publish test of PyPi cu100mkl/ Scala cu92mkl Apr 8, 2019
@stu1130 stu1130 changed the title [WIP] Add publish test of PyPi cu100mkl/ Scala cu92mkl [WIP] Add publish test of PyPi cu100mkl Apr 8, 2019
@stu1130 stu1130 changed the title [WIP] Add publish test of PyPi cu100mkl Add publish test of PyPi cu100mkl Apr 8, 2019
@lanking520
Copy link
Member

Please try to collect all your commit and push it once, the CI consumption for that is very expensive.

@stu1130 stu1130 force-pushed the pypi_gpu_mkl_ci branch 2 times, most recently from 946bdfd to a1e8819 Compare April 9, 2019 16:29
@Roshrini Roshrini added the pr-awaiting-review PR is waiting for code review label Apr 16, 2019
@Roshrini
Copy link
Member

@lanking520 Can you take another look at this PR?
@marcoabreu @zachgk Can you help review?

@wkcn wkcn merged commit 18d4051 into apache:master Apr 18, 2019
@wkcn
Copy link
Member

wkcn commented Apr 18, 2019

Merged. Thank you!

kedarbellare pushed a commit to kedarbellare/incubator-mxnet that referenced this pull request Apr 20, 2019
* test build with cu80

* upgrade to cuda 10

* update the Dockerfile

* update scala gpu ci

* downgrade the version to cu92

* remove the scala gpu test

* add scala gpu test back

* remove the empty line

* fix lint

* undo nvidia docker image

* retrigger CI
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* test build with cu80

* upgrade to cuda 10

* update the Dockerfile

* update scala gpu ci

* downgrade the version to cu92

* remove the scala gpu test

* add scala gpu test back

* remove the empty line

* fix lint

* undo nvidia docker image

* retrigger CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI pr-awaiting-review PR is waiting for code review Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants