Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Dependency Update] Upgrade the libpng to 1.6.35 #14620

Merged
merged 1 commit into from
May 9, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Apr 4, 2019

Description

Upgrade the libpng package to 1.6.35 due to following issues at 1.6.34.

  1. SEGV in function png_free_data more on link1, link2
  2. Division by zero causes LibPNG to crash more on link

Note that the latest stable version is 1.6.36 but has one memory leak issue
memory leak in png_create_info_struct

Checklist

Essentials

  • CI check for scala publish build
  • CI check for python publish build
  • CI check for python gpu publish build
  • Ubuntu 16.04 cu100mkl publish build
  • Ubuntu 16.04 mkl publish build
  • No Performance regression on Imdecode (the script is shown below)
with open('image.jpg', 'rb') as fp:
    str_image = fp.read()

    start = time.time()
for i in range(100):
    image = mx.img.imdecode(str_image)
    image.asnumpy()
print(time.time() - start)

Changes

Comments

@stu1130 stu1130 requested a review from szha as a code owner April 4, 2019 21:29
@piyushghai
Copy link
Contributor

Thanks for your contributions @stu1130. The CI seems to be failing. Can you look into this ?
@mxnet-label-bot Add [Build, pr-awaiting-review]

@marcoabreu marcoabreu added Build pr-awaiting-review PR is waiting for code review labels Apr 5, 2019
@stu1130 stu1130 force-pushed the upgrade_libpng branch 3 times, most recently from b59c7eb to 17a7635 Compare April 26, 2019 21:06
@stu1130 stu1130 changed the title [WIP][Dependency Update] Upgrade the libpng to 1.6.35 [Dependency Update] Upgrade the libpng to 1.6.35 May 1, 2019
@vandanavk
Copy link
Contributor

@marcoabreu @perdasilva for review

@marcoabreu marcoabreu merged commit da02488 into apache:master May 9, 2019
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request May 14, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants