Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Dependency Update] Update libjpeg-turbo to 2.0.2 #14621

Merged
merged 1 commit into from
May 12, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Apr 4, 2019

Description

Upgrade the libjpeg-turbo to 2.0.2 due to the issue at 1.5.90

  1. divide by zero when processing a crafted BMP image

Version 2.0.2 also fixes the performance issue

Fixed a severe performance issue in the Loongson MMI SIMD extensions that occurred when compressing RGB images whose image rows were not 64-bit-aligned.

as stated in the release note

Checklist

Essentials

  • CI check for scala publish build
  • CI check for python publish build
  • CI check for python gpu publish build
  • Ubuntu 16.04 cu100mkl publish build
  • Ubuntu 16.04 mkl publish build
  • No Performance regression on Imdecode (the script is shown below)
with open('image.jpg', 'rb') as fp:
    str_image = fp.read()

    start = time.time()
for i in range(100):
    image = mx.img.imdecode(str_image)
    image.asnumpy()
print(time.time() - start)

Changes

Comments

@stu1130 stu1130 requested a review from szha as a code owner April 4, 2019 22:14
@piyushghai
Copy link
Contributor

Thanks for your contributions @stu1130. The CI seems to be failing. Can you look into this ?
@mxnet-label-bot Add [Build, pr-awaiting-review]

@marcoabreu marcoabreu added Build pr-awaiting-review PR is waiting for code review labels Apr 5, 2019
@piyushghai
Copy link
Contributor

Thanks for your contributions @stu1130. The CI seems to be failing. Can you look into this ?
@mxnet-label-bot Add [Build, pr-awaiting-review]

@roywei
Copy link
Member

roywei commented Apr 29, 2019

@stu1130 ping to take a look at CI. thanks!

@stu1130 stu1130 changed the title [WIP][Dependency Update] Update libjpeg-turbo to 2.0.2 [Dependency Update] Update libjpeg-turbo to 2.0.2 May 2, 2019
@vandanavk
Copy link
Contributor

@mxnet-label-bot update [Build, pr-awaiting-testing]

@marcoabreu marcoabreu added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels May 9, 2019
@stu1130
Copy link
Contributor Author

stu1130 commented May 10, 2019

@mxnet-label-bot update [Build, pr-awaiting-review]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 10, 2019
@szha szha merged commit 8a4ad9f into apache:master May 12, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants