-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update plugin sidebar to new how to guide template #37490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the sidebar tutorial to a single page guide using the new how to template. This makes the guide easier to go through on a single page, cleans up block editor navigation reducing complexity in the navigation and moving the how to Plus adds a new gutenberg-examples code.
ryanwelcher
requested changes
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tutorial! Just a few suggestions for clarity.
Co-authored-by: Ryan Welcher <[email protected]>
Thanks @ryanwelcher for taking the time and going through and offering the suggestions! 🙇 |
ryanwelcher
approved these changes
Dec 17, 2021
mkaz
added a commit
to WordPress/gutenberg-examples
that referenced
this pull request
Dec 17, 2021
mkaz
added a commit
that referenced
this pull request
Dec 18, 2021
An idiosyncracy of WP handbook publishing, there can't be a slug conflict, the changes in #37490 used the same slug due to the filename, which should of matched to the directory. This conflicted with the existing reference document here: https://developer.wordpress.org/block-editor/reference-guides/slotfills/plugin-sidebar/ The published URL should actually be: /how-to-guides/plugin-sidebar-0/ which mapped to the old file instead of the directory. You can confirm by not seeing the Plugin Sidebar in the navigation.
mkaz
added a commit
that referenced
this pull request
Dec 20, 2021
An idiosyncracy of WP handbook publishing, there can't be a slug conflict, the changes in #37490 used the same slug due to the filename, which should of matched to the directory. This conflicted with the existing reference document here: https://developer.wordpress.org/block-editor/reference-guides/slotfills/plugin-sidebar/ The published URL should actually be: /how-to-guides/plugin-sidebar-0/ which mapped to the old file instead of the directory. You can confirm by not seeing the Plugin Sidebar in the navigation.
goldentroll
added a commit
to goldentroll/gutenberg-examples
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the sidebar tutorial to a single page guide using the new how to template. This makes the guide easier to go through on a single page, cleans up block editor navigation reducing complexity in the navigation and moving the how to
Plus adds a new gutenberg-examples code. See this PR on gutenberg-examples repo: WordPress/gutenberg-examples#182
Closes #37343
How has this been tested?
Documentation changes, check for:
Types of changes
Documentation.
/docs/how-to-guides/plugin-sidebar/
already.