Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix plugin sidebar tutorial not publishing #37505

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Dec 18, 2021

Description

An idiosyncracy of WP handbook publishing, there can't be a slug conflict, the changes in #37490 used the same slug due to the filename, which should of matched to the directory.

This conflicted with the existing reference document here: https://developer.wordpress.org/block-editor/reference-guides/slotfills/plugin-sidebar/

The published URL should actually be: /how-to-guides/plugin-sidebar-0/ which mapped to the old file instead of the directory.

How has this been tested?

It is difficult to test because it requires triggering the publishing flow, which is why it was missed previously.

You can confirm it is not currently working by not seeing the Plugin Sidebar in the How to Guides in the block editor sidebar at: http:https://developer.wordpress.org/block-editor/

Types of changes

Documentation.

An idiosyncracy of WP handbook publishing, there can't be a slug conflict,
the changes in #37490 used
the same slug due to the filename, which should of matched to the
directory.

This conflicted with the existing reference document here:
https://developer.wordpress.org/block-editor/reference-guides/slotfills/plugin-sidebar/

The published URL should actually be: /how-to-guides/plugin-sidebar-0/
which mapped to the old file instead of the directory.

You can confirm by not seeing the Plugin Sidebar in the navigation.
@mkaz mkaz requested a review from ajitbohra as a code owner December 18, 2021 02:27
@mkaz mkaz added the [Type] Developer Documentation Documentation for developers label Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants