Dependency notations updates #559

jmfayard · 2022-07-02T11:50:19Z

Hello/bonjour,

What?

Merge changes from PR about dependencies

Jetbrains.exposed.*
Ktor2.*
KotlinX.lincheck.*
KotlinX.multik.*
KotlinX.dataframe.*
KotlinX.deeplearning.*
Koin.navigation

Also

fix typo Spring.boms.springCloud
remove rule androidx.avigation.compose

From other PRs:

Kotlinx.dataframe
Testing.cucumber
Testing.assertj
Testing.jsonAssert
Testing.powermock
Testing.restAssured

Co-authored-by: imashnake0 <[email protected]>

Changes from #543

[Issue-538] Dependency notations for Ktor 2.0.0 [Summary] Ktor 2.0.0 renames a significant number of dependencies, adds new ones, and moves some previously available ones from 1 module into another. It makes sense to make a separate repo for Ktor 2. The full list of artifact changes between 1.6.x and 2.0.0 can be found here: https://ktor.io/docs/migrating-2.html [Fix] Create a Ktor2 dependency group, and include all dependencies listed in the docs: Ktor 2.0.0: https://api.ktor.io/index.html Ktor 1.6.8: https://api.ktor.io/older/1.6.8/index.html [Testing] - Run project tests - publish to maven local, and consume locally Co-authored-by: Brady Aiello <[email protected]>

Co-authored-by: doljae <[email protected]>

See https://developer.android.com/jetpack/androidx/releases/navigation#navigation_compose_version_100_2 Co-authored-by: Johan Reitan <[email protected]>

#550 Co-authored-by: Johan Reitan <[email protected]>

plugins/dependencies/src/main/resources/refreshVersions-rules/androidx-version-alias-rules.txt

sample-kotlin/versions.properties

sample-multi-modules/versions.properties

jmfayard · 2022-07-06T06:47:14Z

plugins/dependencies/src/test/resources/dependencies-versions-key-validated.txt

-org.jetbrains.kotlinx..dataframe-core=version.kotlinxdataframe
-org.jetbrains.kotlinx..dataframe-excel=version.kotlinxdataframe
-org.jetbrains.kotlinx..dataframe=version.kotlinxdataframe
+org.jetbrains.kotlinx..dataframe-arrow=version.kotlinx.dataframe


this has never been released so the change in version name is OK

ConstantinCezarBegu

Thank you!

plugins/dependencies/src/main/kotlin/dependencies/JetBrains.kt

jmfayard · 2022-07-14T11:56:54Z

Todo before merging: move the data frame Gradle Plugin to the Kotlinx namespace

Kotlin/dataframe#128 (comment)

LouisCAD · 2022-07-14T15:48:37Z

Also, renaming the branch before merging to avoid a misleading history.

# Conflicts: # plugins/dependencies/src/test/kotlin/de/fayard/refreshVersions/BundledDependenciesTest.kt

jmfayard · 2022-07-19T17:20:47Z

Also, renaming the branch before merging to avoid a misleading history.

The name of the branch is not part of the git history and git can't rename a branch so I skip this part

jmfayard · 2022-07-19T17:24:37Z

I fixed dataframe to its new kotlinx plugin id.
@LouisCAD any questions before I merge the PR?

LouisCAD · 2022-07-19T17:42:32Z

The merge commit includes the name of the branch, and you can rename a branch in git . You'll only need to submit a superseding PR pointing to the newly pushed branch.

jmfayard · 2022-07-19T19:23:35Z

And then I loose the discussion.

But more importantly that git gymnastic provides no value to the world so I would rather focus on things that do, like reviewing, merging and releasing.

- extensions.datetime - extensions.arbs fix rule

brady-aiello · 2022-07-31T21:56:11Z

@LouisCAD what do you think? Does branch renaming offer more benefit than that of merging sooner and having less PR indirection?

# Conflicts: # docs/dependencies-notations.md

jmfayard · 2022-08-02T07:42:10Z

In the future we want to do small and fast PRs.
Currently there are two huge stale PRs that gets in the way.
I'm merging this one so that there is only one left :)
Instead I created this issue for dependency notations that needs to be reviewed one last time before release

#568

LouisCAD · 2022-08-17T15:33:35Z

plugins/dependencies/src/main/resources/refreshVersions-rules/testing-version-alias-rules.txt

-io.kotest.extensions:kotest-extensions-*
-  ^^^^^^.^^^^^^^^^^.^
+io.kotest.extensions:*
+ ^^^^^^.^^^^^^^^^^


@jmfayard Are you sure about that??

https://search.maven.org/search?q=g:io.kotest.extensions

@LouisCAD I think so, all dependencies inside io.kotest.extension that are maintained have the same version, 1.2.5
Other kotest dependencies are in another namespace

Let's ask @sksamuel if he agrees with the fact that everything non version 1.2.5 (so everything but the arrow extension) has been discontinued.

Hi,

The 1.0.1 konform is current. The arbs is current. The pitest is current.

Basically, some external modules moved to io.kotest.extensions instead of io.kotest and had their versions reset, around 18 months ago.

If you have a central list I can check them over.

jmfayard mentioned this pull request Jul 2, 2022

Add JetBrains Exposed dependencies #515

Closed

jmfayard force-pushed the jetbrains-exposed branch 2 times, most recently from db48688 to f9d0640 Compare July 2, 2022 11:57

jmfayard changed the title ~~➕ Jetbrains.exposed~~ Merge PR with dependencies Jul 2, 2022

This was referenced Jul 2, 2022

Feature/ Add navigation library for Koin group #543

Closed

[Issue-538] Dependency notations for Ktor 2.0.0 #542

Closed

Fix typo #545

Closed

Remove navigation-compose rule #550

Closed

jmfayard and others added 5 commits July 2, 2022 14:33

➕ Jetbrains.exposed [#515]

588b52c

Co-authored-by: imashnake0 <[email protected]>

➕ Koin.navigation

954fde6

Changes from #543

fix: typo Spring.boms.springCloud [#545]

1d2fe2e

Co-authored-by: doljae <[email protected]>

fix: remove navigation-compose rule [#550]

d6b7a97

See https://developer.android.com/jetpack/androidx/releases/navigation#navigation_compose_version_100_2 Co-authored-by: Johan Reitan <[email protected]>

jmfayard force-pushed the jetbrains-exposed branch from a62e7c2 to d6b7a97 Compare July 2, 2022 12:35

➕ KotlinX.(multik|lincheck|deepLearning) [#550]

441ae57

#550 Co-authored-by: Johan Reitan <[email protected]>

This was referenced Jul 2, 2022

Add new Kotlin dependencies #516

Closed

Add support for Ktor v2 #503

Closed

Merge remote-tracking branch 'origin/main' into jetbrains-exposed

57c81bf

jmfayard requested a review from LouisCAD July 2, 2022 12:59

jmfayard added Dependency notations needs-review labels Jul 2, 2022

jmfayard changed the title ~~Merge PR with dependencies~~ Merge PRs with dependency notations Jul 2, 2022

jmfayard changed the title ~~Merge PRs with dependency notations~~ Dependency notations updates Jul 2, 2022

brady-aiello suggested changes Jul 2, 2022

View reviewed changes

plugins/dependencies/src/main/resources/refreshVersions-rules/androidx-version-alias-rules.txt Show resolved Hide resolved

sample-kotlin/versions.properties Outdated Show resolved Hide resolved

sample-multi-modules/versions.properties Outdated Show resolved Hide resolved

dependencies: deprecate Ktor => Ktor1 or Ktor2

4387c2e

pull-request-size bot added the size/XL label Jul 6, 2022

jmfayard commented Jul 6, 2022

View reviewed changes

ConstantinCezarBegu approved these changes Jul 9, 2022

View reviewed changes

plugins/dependencies/src/main/kotlin/dependencies/JetBrains.kt Show resolved Hide resolved

PR: add Jetbrains.ktor1 and Jetbrains.ktor2

d060385

jmfayard mentioned this pull request Jul 10, 2022

Version alignment for plugin org.jetbrains.kotlin.plugin.dataframe? Kotlin/dataframe#128

Closed

jmfayard force-pushed the jetbrains-exposed branch 2 times, most recently from b4e8edc to bc52c85 Compare July 10, 2022 19:35

docs: magnificient page with dependencies notations (#561)

fc3b3e1

jmfayard force-pushed the jetbrains-exposed branch from bc52c85 to fc3b3e1 Compare July 10, 2022 19:52

Merge remote-tracking branch 'origin/main' into jetbrains-exposed

45f69e8

# Conflicts: # plugins/dependencies/src/test/kotlin/de/fayard/refreshVersions/BundledDependenciesTest.kt

dependencies: update dataframe's gradlePlugin

99fffa5

jmfayard added 3 commits July 27, 2022 16:05

dependencies: Testing.kotest

83c0fd4

- extensions.datetime - extensions.arbs fix rule

Merge remote-tracking branch 'origin/main' into jetbrains-exposed

d341f1e

chore: update dependencies markdown from main

e8a66cb

jmfayard force-pushed the jetbrains-exposed branch from e8a66cb to 57c81bf Compare August 2, 2022 07:07

pull-request-size bot added size/XL size/XXL and removed size/XXL size/XL labels Aug 2, 2022

jmfayard mentioned this pull request Aug 2, 2022

BundledDependenciesTest generates dependencies-notations.md #567

Merged

jmfayard added 2 commits August 2, 2022 09:30

Merge remote-tracking branch 'origin/main' into jetbrains-exposed

ecd0d0c

# Conflicts: # docs/dependencies-notations.md

pr: update dependencies-notations.md

b9ee8b8

jmfayard mentioned this pull request Aug 2, 2022

Review bundled dependencies from #559 #568

Closed

jmfayard merged commit a6e58b1 into main Aug 2, 2022

jmfayard deleted the jetbrains-exposed branch August 2, 2022 07:42

LouisCAD reviewed Aug 17, 2022

View reviewed changes

LouisCAD mentioned this pull request Aug 21, 2022

New dependency notations fixup #577

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dependency notations updates #559

Dependency notations updates #559

jmfayard commented Jul 2, 2022 •

edited

Loading

jmfayard Jul 6, 2022

ConstantinCezarBegu left a comment

jmfayard commented Jul 14, 2022

LouisCAD commented Jul 14, 2022

jmfayard commented Jul 19, 2022

jmfayard commented Jul 19, 2022

LouisCAD commented Jul 19, 2022

jmfayard commented Jul 19, 2022

brady-aiello commented Jul 31, 2022

jmfayard commented Aug 2, 2022

LouisCAD Aug 17, 2022

jmfayard Aug 17, 2022

LouisCAD Aug 17, 2022

sksamuel Aug 17, 2022

Dependency notations updates #559

Dependency notations updates #559

Conversation

jmfayard commented Jul 2, 2022 • edited Loading

What?

jmfayard Jul 6, 2022

Choose a reason for hiding this comment

ConstantinCezarBegu left a comment

Choose a reason for hiding this comment

jmfayard commented Jul 14, 2022

LouisCAD commented Jul 14, 2022

jmfayard commented Jul 19, 2022

jmfayard commented Jul 19, 2022

LouisCAD commented Jul 19, 2022

jmfayard commented Jul 19, 2022

brady-aiello commented Jul 31, 2022

jmfayard commented Aug 2, 2022

LouisCAD Aug 17, 2022

Choose a reason for hiding this comment

jmfayard Aug 17, 2022

Choose a reason for hiding this comment

LouisCAD Aug 17, 2022

Choose a reason for hiding this comment

sksamuel Aug 17, 2022

Choose a reason for hiding this comment

jmfayard commented Jul 2, 2022 •

edited

Loading