Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review bundled dependencies from #559 #568

Closed
jmfayard opened this issue Aug 2, 2022 · 2 comments · Fixed by #577
Closed

Review bundled dependencies from #559 #568

jmfayard opened this issue Aug 2, 2022 · 2 comments · Fixed by #577
Labels
needs-review

Comments

@jmfayard
Copy link
Member

jmfayard commented Aug 2, 2022

We want to do small and fast PR but that was not the case of #559 who grew to be too big and stale.
So I merged it and created this issue so that @LouisCAD can check a posteriori whether the following dependencies are OK

  • Jetbrains.exposed.*
  • Ktor2.*
  • KotlinX.lincheck.*
  • KotlinX.multik.*
  • KotlinX.dataframe.*
  • KotlinX.deeplearning.*
  • Koin.navigation
  • Kotlinx.dataframe
  • Testing.cucumber
  • Testing.assertj
  • Testing.jsonAssert
  • Testing.powermock
  • Testing.restAssured
@jmfayard jmfayard mentioned this issue Aug 2, 2022
Merged
@jmfayard
Copy link
Member Author

jmfayard commented Aug 11, 2022 •
edited by LouisCAD
Loading

  • Arrow: review if missing dependencies https://search.maven.org/search?q=a:arrow-stack
  • KotlinX: remove dataframe.gradlePlugin
  • KotlinX: remove import
  • Spring: remove boms.springclmoud
  • Square.okhttp3: move comments to Kdoc
  • Ktor: remove Ktor1 vs Ktor2, use built-in mechanism, add this comment // TODO: Migrate to ktor2. See https://ktor.io/docs/migrating-2.html
  • Testing.kotest.kotestExtensions => move to kotestProperty and check if version is the same for both dependencies. I think it's not Wasn't exactly that, but should be handled now.
  • Remove val jsonAssert = DependencyNotation("org.skyscreamer", "jsonassert")
  • Remove Testing.cucumber because too many dependencies/versions available at https://search.maven.org/search?q=g:io.cucumber
  • Remove Testing.powermock

Not for now

  • How to handle third party DN like for Ktor2 plugins?

@LouisCAD
Copy link
Member

I think Ktor2 version key rules were also forgotten. I'm adding them back.

LouisCAD added a commit that referenced this issue Aug 20, 2022
@LouisCAD
Remove dependency notations we won't maintain
9a752a5 
This commit also removes validation data of some dependency notations,
and reorganizes the Kotest extensions dependency notations.

See #568 (comment)
@LouisCAD LouisCAD mentioned this issue Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New dependency notations fixup Splitties/refreshVersions
2 participants
@jmfayard @LouisCAD