Fix typo #545
Closed
Fix typo #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first PR, and if there are any problems or corrections, please comment. 🙂 |
jmfayard
added a commit
that referenced
this pull request
Jul 2, 2022
|
That's good except that it would be a compilation failure for someone already using it I have changed it to val springCloud = "org.springframework.cloud:spring-cloud-dependencies:_"
@Deprecated("typo", ReplaceWith("springCloud"))
val springclmoud = springCloudand merged it in #559 |
jmfayard
added a commit
that referenced
this pull request
Jul 2, 2022
Co-authored-by: doljae <[email protected]>
|
I never thought of considering backwards compatibility in this way 😮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix typo
springclmoud->springCloudWhy?
Because I found a typo.
How?
Just fix all
springclmoudtospringCloudin whole project.Testing?
CI/CD result looks fine.