Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cpe error message regression #2105

Merged
merged 3 commits into from
Jul 2, 2024
Merged

fix: cpe error message regression #2105

merged 3 commits into from
Jul 2, 2024

Conversation

vinayhospete
Copy link
Member

Regression after eslint fix #1918

Expected error message: "SyntaxError: no closing braces found in '{expression' after pos:0"

Current error message: no closing braces found in '{expression' after pos:0"

@vinayhospete vinayhospete requested a review from a team as a code owner July 2, 2024 10:41
Copy link

changeset-bot bot commented Jul 2, 2024

🦋 Changeset detected

Latest commit: cfd0980

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heimwege
Copy link
Contributor

heimwege commented Jul 2, 2024

This line has also been changed in #1918. Does it need to be adjusted as well?

@vinayhospete
Copy link
Member Author

This line has also been changed in #1918. Does it need to be adjusted as well?

Not required. As error message is just logged and not shown on UI.

Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

  • changeset ok
  • code change is minimal
  • excellent test coverage 😸

Copy link

sonarcloud bot commented Jul 2, 2024

Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Simple change
  • Changeset present
  • Did not test manually

@vinayhospete vinayhospete merged commit 0e0c286 into main Jul 2, 2024
13 checks passed
@vinayhospete vinayhospete deleted the fix/cpe/regression branch July 2, 2024 14:44
devinea added a commit that referenced this pull request Jul 4, 2024
* origin/main:
  chore: apply latest changesets
  fix: i18n bindings validation fails for nested *.properties files (#2021)
  chore: apply latest changesets
  fix: Release version of @sap-ux/project-access with filterDataSourcesByType (#2114)
  chore: apply latest changesets
  fix: Incorrect change mapping for 'reference' property for Adaptation Project's writers (#2107)
  chore: apply latest changesets
  fix: cpe error message regression (#2105)
  chore: apply latest changesets
  feat(fiori elements writer): 1924 reuse libs for UI.note annotation (#2047)
  chore: apply latest changesets
  fix: add description in i18n.properties (#2086)
devinea added a commit that referenced this pull request Jul 4, 2024
* origin/main: (118 commits)
  chore - Update actions - fix broken pipeline (#2118)
  chore: apply latest changesets
  fix: i18n bindings validation fails for nested *.properties files (#2021)
  chore: apply latest changesets
  fix: Release version of @sap-ux/project-access with filterDataSourcesByType (#2114)
  chore: apply latest changesets
  fix: Incorrect change mapping for 'reference' property for Adaptation Project's writers (#2107)
  chore: apply latest changesets
  fix: cpe error message regression (#2105)
  chore: apply latest changesets
  feat(fiori elements writer): 1924 reuse libs for UI.note annotation (#2047)
  chore: apply latest changesets
  fix: add description in i18n.properties (#2086)
  chore: apply latest changesets
  fix: update access modifier (#2103)
  chore: apply latest changesets
  fix: Duplicate i18n model in manifest.appdescr_variant for Adp Project (#2101)
  chore: apply latest changesets
  fix(axios-extension): parsing of service gen response (#2088)
  chore: apply latest changesets
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants