Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n bindings validation fails for nested *.properties files #2021

Merged
merged 12 commits into from
Jul 4, 2024

Conversation

mmilko01
Copy link
Contributor

@mmilko01 mmilko01 commented Jun 7, 2024

Fix for: #2020.

  • Checks nested *.properties files when validating key.

Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: f50a378

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikmace nikmace requested a review from a team June 10, 2024 06:58
@nikmace nikmace added bug Something isn't working preview-middleware @sap-ux/preview-middleware preview-middleware-client labels Jun 10, 2024
packages/preview-middleware-client/src/flp/init.ts Outdated Show resolved Hide resolved
packages/preview-middleware-client/src/flp/init.ts Outdated Show resolved Hide resolved
packages/preview-middleware-client/src/flp/init.ts Outdated Show resolved Hide resolved
packages/preview-middleware-client/src/flp/init.ts Outdated Show resolved Hide resolved
@mmilko01 mmilko01 marked this pull request as ready for review June 10, 2024 14:16
@mmilko01 mmilko01 requested a review from a team as a code owner June 10, 2024 14:16
@nikmace nikmace self-requested a review June 11, 2024 07:23
@nikmace nikmace requested a review from voicis June 11, 2024 11:19
voicis
voicis previously approved these changes Jun 11, 2024
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code adheres to development guidelines
  • Review comments addressed
  • Good test coverage
  • Tested locally

nikmace
nikmace previously approved these changes Jun 12, 2024
Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good
Coverage is good
Did not test manually

@mmilko01 mmilko01 dismissed stale reviews from nikmace and voicis via f50a378 July 3, 2024 13:51
@mmilko01 mmilko01 requested review from voicis and nikmace July 3, 2024 13:52
Copy link

sonarcloud bot commented Jul 3, 2024

Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good
Test coverage is good
Did not test manually

@mmilko01 mmilko01 merged commit 8f57ac2 into main Jul 4, 2024
13 checks passed
@mmilko01 mmilko01 deleted the fix/2020/i18n_validation_fails branch July 4, 2024 09:05
devinea added a commit that referenced this pull request Jul 4, 2024
* origin/main:
  chore: apply latest changesets
  fix: i18n bindings validation fails for nested *.properties files (#2021)
  chore: apply latest changesets
  fix: Release version of @sap-ux/project-access with filterDataSourcesByType (#2114)
  chore: apply latest changesets
  fix: Incorrect change mapping for 'reference' property for Adaptation Project's writers (#2107)
  chore: apply latest changesets
  fix: cpe error message regression (#2105)
  chore: apply latest changesets
  feat(fiori elements writer): 1924 reuse libs for UI.note annotation (#2047)
  chore: apply latest changesets
  fix: add description in i18n.properties (#2086)
devinea added a commit that referenced this pull request Jul 4, 2024
* origin/main: (118 commits)
  chore - Update actions - fix broken pipeline (#2118)
  chore: apply latest changesets
  fix: i18n bindings validation fails for nested *.properties files (#2021)
  chore: apply latest changesets
  fix: Release version of @sap-ux/project-access with filterDataSourcesByType (#2114)
  chore: apply latest changesets
  fix: Incorrect change mapping for 'reference' property for Adaptation Project's writers (#2107)
  chore: apply latest changesets
  fix: cpe error message regression (#2105)
  chore: apply latest changesets
  feat(fiori elements writer): 1924 reuse libs for UI.note annotation (#2047)
  chore: apply latest changesets
  fix: add description in i18n.properties (#2086)
  chore: apply latest changesets
  fix: update access modifier (#2103)
  chore: apply latest changesets
  fix: Duplicate i18n model in manifest.appdescr_variant for Adp Project (#2101)
  chore: apply latest changesets
  fix(axios-extension): parsing of service gen response (#2088)
  chore: apply latest changesets
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview-middleware @sap-ux/preview-middleware preview-middleware-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants