feat(fiori elements writer): 1924 reuse libs for UI.note annotation #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f650597 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tested manually |
…or-ui.note-annotation
…or-ui.note-annotation
…or-ui.note-annotation
…or-ui.note-annotation
…or-ui.note-annotation
…or-ui.note-annotation
cianmSAP
requested changes
Jun 21, 2024
Co-authored-by: Cian Morrin <[email protected]>
Co-authored-by: Cian Morrin <[email protected]>
Co-authored-by: Cian Morrin <[email protected]>
…or-ui.note-annotation
tobiasqueck
previously approved these changes
Jul 1, 2024
…or-ui.note-annotation
…annotation' of github.com:SAP/open-ux-tools into feat/fiori-elements-writer/1924-reuse-libs-for-ui.note-annotation
…or-ui.note-annotation
devinea
previously approved these changes
Jul 1, 2024
IainSAP
previously approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Thanks @korotkovao
- Code is easy to understand
- Tests added to cover
- Comments addressed
|
Could you please fix https://sonarcloud.io/project/issues?id=SAP_open-ux-tools&pullRequest=2047&resolved=false&sinceLeakPeriod=true? Otherwise, it is ready for merging |
…or-ui.note-annotation
…or-ui.note-annotation
|
tobiasqueck
approved these changes
Jul 2, 2024
|
Thank you @devinea @tobiasqueck @IainSAP @cianmSAP |
korotkovao
deleted the
feat/fiori-elements-writer/1924-reuse-libs-for-ui.note-annotation
branch
devinea
added a commit
that referenced
this pull request
Jul 4, 2024
* origin/main: chore: apply latest changesets fix: i18n bindings validation fails for nested *.properties files (#2021) chore: apply latest changesets fix: Release version of @sap-ux/project-access with filterDataSourcesByType (#2114) chore: apply latest changesets fix: Incorrect change mapping for 'reference' property for Adaptation Project's writers (#2107) chore: apply latest changesets fix: cpe error message regression (#2105) chore: apply latest changesets feat(fiori elements writer): 1924 reuse libs for UI.note annotation (#2047) chore: apply latest changesets fix: add description in i18n.properties (#2086)
devinea
added a commit
that referenced
this pull request
Jul 4, 2024
* origin/main: (118 commits) chore - Update actions - fix broken pipeline (#2118) chore: apply latest changesets fix: i18n bindings validation fails for nested *.properties files (#2021) chore: apply latest changesets fix: Release version of @sap-ux/project-access with filterDataSourcesByType (#2114) chore: apply latest changesets fix: Incorrect change mapping for 'reference' property for Adaptation Project's writers (#2107) chore: apply latest changesets fix: cpe error message regression (#2105) chore: apply latest changesets feat(fiori elements writer): 1924 reuse libs for UI.note annotation (#2047) chore: apply latest changesets fix: add description in i18n.properties (#2086) chore: apply latest changesets fix: update access modifier (#2103) chore: apply latest changesets fix: Duplicate i18n model in manifest.appdescr_variant for Adp Project (#2101) chore: apply latest changesets fix(axios-extension): parsing of service gen response (#2088) chore: apply latest changesets ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEATURE - Automatically enable the notes reuse component if a service is annotated with UI.Note #1924
Check if the provided metadata contains the
UI.Noteannotation. If yes, then addnw.core.gbt.notes.lib.reuseas a dependency to themanifest.json.