crsf_rc: add bind command #23294
crsf_rc: add bind command #23294
Conversation
benjinne
force-pushed
the
pr-crsf-binding
branch
from
8a47282
to
17aa86a
Compare
| if (!strcmp(verb, "bind")) { | ||
| uORB::Publication<vehicle_command_s> vehicle_command_pub{ORB_ID(vehicle_command)}; | ||
| vehicle_command_s vcmd{}; | ||
| vcmd.command = vehicle_command_s::VEHICLE_CMD_START_RX_PAIR; |
There was a problem hiding this comment.
FYI this might get weird if other modules (px4io, other rc_input, etc) are running.
There was a problem hiding this comment.
I think in general there's only one rc module running per vehicle. If we expect multiple, then maybe we can handle this with the command parameters
| 0xE8, // Packet CRC8 | ||
| }; | ||
|
|
||
| return _uart->write((void *) bindFrame, 9); |
There was a problem hiding this comment.
Is there any acknowledgement or mechanism for checking?
There was a problem hiding this comment.
I didn't see any in the betaflight code or ardupilot code. To verify it was successful I think the assumption is you verify the receiver lights blink rapidly signifying it's in bind mode
|
@dagar I've tested and verified that this works. |
Solved Problem
Ability to bind using the crsf protocol
Fixes #23281
Solution
Changelog Entry
For release notes:
Alternatives
Add to rc_input module if needed
Test coverage
I assume vehicle command to bind comes from QGC and we may need to update QGC's UI