Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

627 ljw mov parallel #628

Closed
wants to merge 99 commits into from
Closed

627 ljw mov parallel #628

wants to merge 99 commits into from

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Nov 13, 2019

Resolve #627

@lee1043 lee1043 changed the title 627 ljw mo v parallel 627 ljw mov parallel Nov 13, 2019
@gleckler1
Copy link
Contributor

@lee1043 Looks like some checks failed :-(

@lee1043
Copy link
Contributor Author

lee1043 commented Nov 13, 2019

@muryanto1 I think I have resolved all about flake8 related test failure, but the test is still failing and I don't have a clear idea, would you mind take a look? Thank you in advance.

@coveralls
Copy link

coveralls commented Nov 13, 2019

Coverage Status

Coverage remained the same at 76.773% when pulling e583bed on 627_ljw_MoV_parallel into 0bbec22 on master.

@lee1043 lee1043 requested a review from gleckler1 July 19, 2020 23:52
@lee1043
Copy link
Contributor Author

lee1043 commented Jul 19, 2020

All test passed on circle ci except for linux_pmp_py2, linux_pmp_py3 and macos_pmp_py2, macos_pmp_py3. Following the comment of @muryanto1 at #639 (comment) I think it is okay to be merged now.

@gleckler1
Copy link
Contributor

@lee1043 Why all the changes to diurnal on this branch? I'm not sure this is correct as we have been using the diurnal branch heavily in master.

@lee1043
Copy link
Contributor Author

lee1043 commented Jul 22, 2020

@gleckler1 that is weird because I haven't touched anything from diurnal. Hmm.. let me check. Thanks for pointing it out!

@gleckler1
Copy link
Contributor

@lee1043 when was the last time this was updated with master? Maybe diurnal was changed after that?

@lee1043
Copy link
Contributor Author

lee1043 commented Jul 22, 2020

@gleckler1 yes, the change in diurnal was after my latest update with master (using the rebase functionality). I have tried rebase again with the latest current one but the rebase process was struggling to me.

@lee1043 lee1043 mentioned this pull request Jul 23, 2020
@lee1043
Copy link
Contributor Author

lee1043 commented Jul 23, 2020

I am migrating necessary changes to a new branch that generated based on the current master and opened another PR #643. @gleckler1 I will let you know when the new PR is ready for reviewing.

@lee1043 lee1043 closed this Jul 23, 2020
@lee1043 lee1043 deleted the 627_ljw_MoV_parallel branch October 21, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel run for modes of variability metrics code
6 participants