-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
627 ljw mov parallel #628
627 ljw mov parallel #628
Conversation
@lee1043 Looks like some checks failed :-( |
@muryanto1 I think I have resolved all about flake8 related test failure, but the test is still failing and I don't have a clear idea, would you mind take a look? Thank you in advance. |
…attern by its own stdv
…attern by its own stdv
…or waiting model with many runs
All test passed on circle ci except for linux_pmp_py2, linux_pmp_py3 and macos_pmp_py2, macos_pmp_py3. Following the comment of @muryanto1 at #639 (comment) I think it is okay to be merged now. |
@lee1043 Why all the changes to diurnal on this branch? I'm not sure this is correct as we have been using the diurnal branch heavily in master. |
@gleckler1 that is weird because I haven't touched anything from diurnal. Hmm.. let me check. Thanks for pointing it out! |
@lee1043 when was the last time this was updated with master? Maybe diurnal was changed after that? |
@gleckler1 yes, the change in diurnal was after my latest update with master (using the rebase functionality). I have tried rebase again with the latest current one but the rebase process was struggling to me. |
I am migrating necessary changes to a new branch that generated based on the current master and opened another PR #643. @gleckler1 I will let you know when the new PR is ready for reviewing. |
Resolve #627