-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
627 ljw mov parallel 2 #643
Conversation
lee1043
commented
Jul 23, 2020
•
edited
Loading
edited
- Resolve Issue Parallel run for modes of variability metrics code #627
- Here, the changes were migrated from PR 627 ljw mov parallel #628 because the previous branch was based on outdated master and rebase process was not going smooth.
NOTE: Some more cleaning up and checking needed before fully merging to master. Please do not merge this until told. |
@gleckler1 I believe this branch is ready to be merged. |
…di_metrics into 627_ljw_MoV_parallel_2
@lee1043 Before we merge this with master lets first settle on where to put our in-house param files, e.g., /variability_mode/doc/myParam_test.py → ...ariability_mode/param/myParam_demo_NAM.py We know have another PR with a proposal of where to put these ;-) There are some failures with the circleci tests, but I recall you indicated Lina suggested we can live with them. Do you know if they will they count against our "success" rate? |
@muryanto1 Some tests are still failing even after I have taken care of all flake8 related issues. I see below log from circle ci, any chance that is looking familiar to you?
|
@lee1043 HTTP Error indicates there is a network issue in circle ci at the time the test ran, please do "Rerun Workflow from Failed" in circleci. |
@muryanto1 will do, thank you very much for your comment. |
@gleckler1 internal parameter files were moved to under the sample_setups directory |
@lee1043 It looks like the job has stalled because we are using the free version. |
… copied influence to the original
@lee1043 Shall I merge this now? |
@gleckler1 yes please :) |