Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

627 ljw mov parallel 2 #643

Merged
merged 38 commits into from
Nov 12, 2020
Merged

627 ljw mov parallel 2 #643

merged 38 commits into from
Nov 12, 2020

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Jul 23, 2020

@lee1043 lee1043 mentioned this pull request Jul 23, 2020
@lee1043
Copy link
Contributor Author

lee1043 commented Jul 23, 2020

NOTE: Some more cleaning up and checking needed before fully merging to master. Please do not merge this until told.

@lee1043 lee1043 self-assigned this Sep 4, 2020
@lee1043
Copy link
Contributor Author

lee1043 commented Oct 21, 2020

@gleckler1 I believe this branch is ready to be merged.

@gleckler1
Copy link
Contributor

@lee1043 Before we merge this with master lets first settle on where to put our in-house param files, e.g.,

/variability_mode/doc/myParam_test.py → ...ariability_mode/param/myParam_demo_NAM.py

We know have another PR with a proposal of where to put these ;-)

There are some failures with the circleci tests, but I recall you indicated Lina suggested we can live with them. Do you know if they will they count against our "success" rate?

@lee1043
Copy link
Contributor Author

lee1043 commented Nov 5, 2020

@muryanto1 Some tests are still failing even after I have taken care of all flake8 related issues. I see below log from circle ci, any chance that is looking familiar to you?

CondaHTTPError: HTTP 504 GATEWAY TIME-OUT for url <https://conda.anaconda.org/cdat/label/nightly/linux-64/vtk-cdat-8.2.0.8.2.2020.07.20.18.56.g3aa9eaf-py36_mesalibh3081630_0.tar.bz2>
Elapsed: 01:00.037931
CF-RAY: 5ed3f105c8e92598-IAD

An HTTP error occurred when trying to retrieve this URL.
HTTP errors are often intermittent, and a simple retry will get you on your way.

@muryanto1
Copy link
Contributor

@lee1043 HTTP Error indicates there is a network issue in circle ci at the time the test ran, please do "Rerun Workflow from Failed" in circleci.

@lee1043
Copy link
Contributor Author

lee1043 commented Nov 5, 2020

@muryanto1 will do, thank you very much for your comment.

@lee1043
Copy link
Contributor Author

lee1043 commented Nov 10, 2020

@gleckler1 internal parameter files were moved to under the sample_setups directory

@gleckler1
Copy link
Contributor

@lee1043 It looks like the job has stalled because we are using the free version.

@gleckler1
Copy link
Contributor

@lee1043 Shall I merge this now?

@lee1043
Copy link
Contributor Author

lee1043 commented Nov 12, 2020

@gleckler1 yes please :)

@gleckler1 gleckler1 merged commit bf374d4 into master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants