Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated conda recipes #639

Merged
merged 15 commits into from
Jul 9, 2020
Merged

Use updated conda recipes #639

merged 15 commits into from
Jul 9, 2020

Conversation

muryanto1
Copy link
Contributor

add Makefile and use 'master' branch of cdat/cdat since 'validateNightlyNew' branch has been merged to 'master'.

@muryanto1 muryanto1 requested a review from lee1043 July 1, 2020 22:05
@muryanto1 muryanto1 mentioned this pull request Jul 1, 2020
@muryanto1
Copy link
Contributor Author

muryanto1 commented Jul 9, 2020

@lee1043 https://circleci.com/gh/PCMDI/pcmdi_metrics/tree/use_updated_conda_recipes all test runs passed. those circleci job like linux_pmp_* macos_pmp_* jobs that are listed above that still say "Required" are old circleci jobs.
The build above picked up the genutil that has @jasonb5 's fix for CDAT/genutil#38.
NOTE that I added py36, py37, py38 for both macos and linux. As a result, each commit triggers builds and test runs that take a long time to finish. It is up to you if you want to include all those configs.

@lee1043
Copy link
Contributor

lee1043 commented Jul 9, 2020

@muryanto1 thank you for the update. Once all tests passes on circle ci, which is pending now, I will merge this.

@muryanto1
Copy link
Contributor Author

@lee1043 all tests passed, please see the list of tests under "Some checks haven't completed yet". build-linux, build-macos, test-linux-3.6-mpi_mpich, test-linux-3.6-mpi_openmpi, test-linux-3.6-nompi, etc...they are all jobs from .circleci/config.yml, and they all passed. For some reason the old jobs linux_pmp_py2, linux_pmp_py3 and macos_pmp_py2, macos_pmp_py3 are still listed up there under "Some checks haven't completed yet". I do not know why.

@lee1043
Copy link
Contributor

lee1043 commented Jul 9, 2020

@muryanto1 I see, thanks for clarifying. Because of the "Some checks haven't completed yet" showing up, I thought it was still processing. I am merging it now.

@lee1043 lee1043 merged commit 3c6a872 into master Jul 9, 2020
@lee1043 lee1043 deleted the use_updated_conda_recipes branch July 9, 2020 20:13
@lee1043 lee1043 mentioned this pull request Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants