rocm-related: 5.3.0 -> 5.3.1 & aggregate #198770

Madouura · 2022-10-31T09:56:39Z

Description of changes

Most hashes did not change, version bump to maintain compatibility.
Tracking: #197885

Things done

Built on platform(s)
- x86_64-linux
- aarch64-linux
- x86_64-darwin
- aarch64-darwin
For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
Tested, as applicable:
- NixOS test(s) (look inside nixos/tests)
- and/or package tests
- or, for functions and "core" functionality, tests in lib/tests or pkgs/test
- made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)
- (Package updates) Added a release notes entry if the change is major or breaking
- (Module updates) Added a release notes entry if the change is significant
- (Module addition) Added a release notes entry if adding a new NixOS module
- (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
Fits CONTRIBUTING.md.

Flakebi

Thanks again!

I tested some OpenCL and hip applications and they worked fine.

LunNova · 2022-10-31T19:35:28Z

Result of nixpkgs-review pr 198770 run on x86_64-linux 1

15 packages built:

blender-hip
hip
llvmPackages_rocm.clang
llvmPackages_rocm.clangNoCompilerRt
llvmPackages_rocm.llvm
rocclr
rocm-cmake
rocm-comgr
rocm-device-libs
rocm-opencl-icd
rocm-opencl-runtime
rocm-runtime
rocm-smi
rocm-thunk
rocminfo

Madouura · 2022-11-04T13:22:26Z

@lovesegfault Rolled into this PR, since they all rely on this PR anyway.

lovesegfault

LGTM

Will wait on @Flakebi's review to merge

Madouura · 2022-11-04T16:10:09Z

Rebuilt everything to make sure this PR is safe to merge.

Final result:

nixpkgs on  pr/aggr [$] took 42m42s 
❯ nix-build . -A llvmPackages_rocm.llvm -A llvmPackages_rocm.clang -A hip -A rocclr -A rocm-comgr -A rocm-device-libs -A rocm-opencl-runtime -A rocm-runtime -A rocm-thunk -A rocm-cmake -A rocminfo -A rocm-smi -A rocprim -A hipcub -A rocsparse -A hipsparse -A rccl -A rocfft -A tensile -A rocblas -A miopengemm -A composable_kernel -A clang-ocl -A rocthrust
/nix/store/qn2f45hc8qi4214ss1dcmrxp5vl0iaw1-rocm-llvm-5.3.1
/nix/store/4nvx5fla45198skmxihg83wlw0k8rr57-rocm-llvm-wrapper-5.3.1
/nix/store/9mpxwijw14zkzlz2icalfkh6pb408zmq-hip-5.3.1
/nix/store/sss84hpsbfgm2xd9va9fjb23x7dfwrnj-rocclr-5.3.1
/nix/store/6vaagd85p5zwgmrfyraz1pgirbpaj73r-rocm-comgr-5.3.1
/nix/store/cf91952wf8dy4fjmjyqi5as41gjb3kc2-rocm-device-libs-5.3.1
/nix/store/a47gbycs0lfzrbfhd6s67q65xsq13rn2-rocm-opencl-runtime-5.3.1
/nix/store/9b0rir8yazpb40b1gm2xf5ljyn7ymn34-rocm-runtime-5.3.1
/nix/store/zbj0m25c60v73fr20g113m783xdgrppi-rocm-thunk-5.3.1
/nix/store/d5x36ns4lg734wkbyqbdb6ab7iyi5vda-rocm-cmake-5.3.1
/nix/store/ybbbxlxgwqp4y2jgdkjr1ddjsys9364g-rocminfo-5.3.1
/nix/store/2q6il1lcanja2w39w26r15hxxrzip287-rocm-smi-5.3.1
/nix/store/hgxqja6cjbrirzx46m8cwyx4jdy6v884-rocprim-2.11.0-5.3.1
/nix/store/s66c7hw4fgb8vc80qyjplcl6shjdxfk5-hipcub-2.12.0-5.3.1
/nix/store/a6xnva6sihlh9dav373j54zkhwzdjd3v-rocsparse-2.3.2-5.3.1
/nix/store/9l231q7bwndn2parilii8w164j6ry6c1-hipsparse-2.3.1-5.3.1
/nix/store/jp0gnv8m96m2zd8yy5ayfv4mv16gjd6x-rccl-2.12.10-5.3.1
/nix/store/80biz86ywzh6q1sxvs4xi1j72rywg185-rocfft-1.0.18-5.3.1
/nix/store/3ak9ks0bbxdp20ph0jiyvy5s2519jg0l-python3.10-tensile-4.34.0-5.3.1
/nix/store/xv3dshh1fsbr0yb41qhmrhivy7x57z17-rocblas-2.45.0-5.3.1
/nix/store/cpgzc3n4h9lml6n0y6kfc5hwqvw88l8r-miopengemm-5.3.1
/nix/store/6y2b4y2a94vqv8g1dfzkga7x9r1r1j74-composable_kernel-unstable-2022-11-02
/nix/store/mickbgzbca3x0ckcc3nirmj8vm7lq3yf-clang-ocl-5.3.1
/nix/store/lm5jm9mj548fcjknf3n5b7hyrlifffv8-rocthrust-2.16.0-5.3.1

Also double checked all package roots with find ${pkg_dir}, everything checks out.

Flakebi

Thanks, just two questions inline.

Flakebi · 2022-11-09T09:27:28Z

pkgs/development/libraries/rocsparse/default.nix

+ matrices = lib.optionalAttrs (buildTests || buildBenchmarks) import ./deps.nix {
+ inherit fetchzip;
+ mirror1 = "https://sparse.tamu.edu/MM";
+ mirror2 = "https://www.cise.ufl.edu/research/sparse/MM";
+ };


Are these the same as in hipsparse/deps.nix?
Maybe you could add them as rocsparse.passthrough.matrices and import them in hipsparse instead of duplicating them?

That's a good idea, I'll add it to a TODO list in the tracking issue.
If for some reason hipsparse begins using different matricies, as long as some of them are the same we can still do this as well.

Flakebi · 2022-11-09T10:07:34Z

pkgs/development/libraries/rocsparse/default.nix

+ outputs = [
+ "out"
+ ] ++ lib.optionals (buildTests || buildBenchmarks) [
+ "test"


How can I run the tests? I get

$ result-test/bin/rocsparse-test "hipErrorNoBinaryForGpu: Unable to find code object for all current devices!" fish: Job 1, 'result-test/bin/rocsparse-test' terminated by signal SIGABRT (Abort)

I guess it either needs something in my environment or I have to specify the GPU somewhere?

Probably yes, see: https://github.com/Madouura/nixos-config/blob/0e4236c18a468abd300b3df5c2657dba6f763ec0/hosts/machines/ura/modules/system/hardware.nix#L6-L9

vcunat · 2022-11-11T12:49:40Z

rocfft produces 3.6 GiB output. That's too large, so Hydra.nixos.org always fails after finishing the costly build. Unless you can improve this, I suggest adding meta.hydraPlatforms = []; so that this pointless build isn't repeated there every time without succeeding.

Madouura · 2022-11-11T14:21:45Z

AFAIK it can't be improved, it's just a ridiculously large build.
IIRC, it's all in /lib too.
I'll submit a PR for it.

Madouura · 2022-11-11T14:28:54Z

@vcunat #200705

vcunat · 2022-11-11T14:41:24Z

Yes, I looked before, it's gigabytes of so-libraries.

Madouura requested a review from matthewbauer as a code owner October 31, 2022 09:56

ofborg bot requested review from Flakebi, lovesegfault and acowley October 31, 2022 10:07

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Oct 31, 2022

Flakebi approved these changes Oct 31, 2022

View reviewed changes

LunNova approved these changes Oct 31, 2022

View reviewed changes

Madouura changed the title ~~rocm-related: 5.3.0 -> 5.3.1~~ rocm-related: 5.3.0 -> 5.3.1 & aggregate Nov 4, 2022

Madouura added 9 commits November 4, 2022 08:19

hip: 5.3.0 -> 5.3.1

31be9bf

llvm-rocm: 5.3.0 -> 5.3.1

d93f2db

rocclr: 5.3.0 -> 5.3.1

f4a0c6a

rocm-comgr: 5.3.0 -> 5.3.1

7d56666

rocm-device-libs: 5.3.0 -> 5.3.1

d3bf50d

rocm-opencl-runtime: 5.3.0 -> 5.3.1

d933470

rocm-runtime: 5.3.0 -> 5.3.1

dda4ff5

rocm-thunk: 5.3.0 -> 5.3.1

d3e1db3

rocm-cmake: 5.3.0 -> 5.3.1

2a3f5e3

Madouura added 3 commits November 4, 2022 08:20

composable_kernel: init at unstable-2022-11-02

d147c1d

clang-ocl: init at 5.3.1

edbebe1

rocthrust: init at 2.16.0-5.3.1

ec690a4

Madouura force-pushed the pr/aggr branch from 8304808 to ec690a4 Compare November 4, 2022 13:20

ofborg bot added 8.has: package (new) and removed 2.status: merge conflict labels Nov 4, 2022

ofborg bot requested a review from Flakebi November 4, 2022 13:31

lovesegfault approved these changes Nov 4, 2022

View reviewed changes

lovesegfault merged commit 1577208 into NixOS:master Nov 6, 2022

Madouura deleted the pr/aggr branch November 6, 2022 21:14

Flakebi reviewed Nov 9, 2022

View reviewed changes

Madouura mentioned this pull request Nov 11, 2022

rocfft: set hydraPlatforms due to large output #200705

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rocm-related: 5.3.0 -> 5.3.1 & aggregate #198770

rocm-related: 5.3.0 -> 5.3.1 & aggregate #198770

Madouura commented Oct 31, 2022 •

edited

Loading

Flakebi left a comment

LunNova commented Oct 31, 2022

Madouura commented Nov 4, 2022

lovesegfault left a comment

Madouura commented Nov 4, 2022 •

edited

Loading

Flakebi left a comment

Flakebi Nov 9, 2022

Madouura Nov 9, 2022 •

edited

Loading

Flakebi Nov 9, 2022

Madouura Nov 9, 2022

vcunat commented Nov 11, 2022

Madouura commented Nov 11, 2022

Madouura commented Nov 11, 2022

vcunat commented Nov 11, 2022

rocm-related: 5.3.0 -> 5.3.1 & aggregate #198770

rocm-related: 5.3.0 -> 5.3.1 & aggregate #198770

Conversation

Madouura commented Oct 31, 2022 • edited Loading

Description of changes

Things done

Flakebi left a comment

Choose a reason for hiding this comment

LunNova commented Oct 31, 2022

Madouura commented Nov 4, 2022

lovesegfault left a comment

Choose a reason for hiding this comment

Madouura commented Nov 4, 2022 • edited Loading

Flakebi left a comment

Choose a reason for hiding this comment

Flakebi Nov 9, 2022

Choose a reason for hiding this comment

Madouura Nov 9, 2022 • edited Loading

Choose a reason for hiding this comment

Flakebi Nov 9, 2022

Choose a reason for hiding this comment

Madouura Nov 9, 2022

Choose a reason for hiding this comment

vcunat commented Nov 11, 2022

Madouura commented Nov 11, 2022

Madouura commented Nov 11, 2022

vcunat commented Nov 11, 2022

Madouura commented Oct 31, 2022 •

edited

Loading

Madouura commented Nov 4, 2022 •

edited

Loading

Madouura Nov 9, 2022 •

edited

Loading