Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hipsparse: init at 2.3.1-5.3.1 #197487

Closed
wants to merge 2 commits into from
Closed

hipsparse: init at 2.3.1-5.3.1 #197487

wants to merge 2 commits into from

Conversation

Madouura
Copy link
Contributor

@Madouura Madouura commented Oct 24, 2022 •
edited
Loading

Description of changes

Tracking: #197885
Fourth part in a whole bunch of porting...
For now, no nixosTests or enabled buildTests.
Seems to be an upstream issue, AUR package also had to disable some things.
hipSPARSE tests working!
hipsparse.passthru.tests will likely always fail due to it being in a vm, but I have confirmed the tests generated do work on hardware.
Depends on #197455

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Oct 24, 2022
@Madouura Madouura mentioned this pull request Oct 26, 2022
Open
34 tasks
@Madouura
Copy link
Contributor Author

Madouura commented Oct 27, 2022 •
edited
Loading

For samples and tests, there seems to be some sort of either toolchain mixing or somehow the C++ standard gets reset to something not 14. (It does get set to 11 in clients, but I don't think that's what is causing this...)

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 27, 2022
@Madouura
Copy link
Contributor Author

Turns out it wasn't a toolchain mixing issue. Anyway, tests work now.

@Madouura Madouura changed the title hipsparse: init at 2.3.1-5.3.0 hipsparse: init at 2.3.1-5.3.1 Oct 30, 2022
@Madouura
Copy link
Contributor Author

Madouura commented Nov 4, 2022

Rolled into #198770

@Madouura Madouura closed this Nov 4, 2022
@Madouura Madouura deleted the pr/hipsparse branch November 4, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault left review comments

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Madouura @lovesegfault