-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocsparse: init at 2.3.2-5.3.1 #197455
Closed
Closed
rocsparse: init at 2.3.2-5.3.1 #197455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
label
Oct 23, 2022
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild
10.rebuild-linux: 0
This PR does not cause any packages to rebuild
labels
Oct 23, 2022
Madouura
force-pushed
the
pr/rocsparse
branch
from
October 24, 2022 03:49
9395ae1
to
fedd71d
Compare
Cleaned up some things. |
13 tasks
Madouura
force-pushed
the
pr/rocsparse
branch
from
October 24, 2022 05:33
fedd71d
to
c01ee18
Compare
Changed some overly-verbose paths. |
Madouura
force-pushed
the
pr/rocsparse
branch
2 times, most recently
from
October 24, 2022 15:50
a8f0b5c
to
fd40737
Compare
Madouura
force-pushed
the
pr/rocsparse
branch
2 times, most recently
from
October 27, 2022 18:51
a2cb8bf
to
462e36d
Compare
Before not all tests were passing after I ran it longer because [----------] Global test environment tear-down
[==========] 282847 tests from 328 test suites ran. (9524521 ms total)
[ PASSED ] 282847 tests. |
Madouura
force-pushed
the
pr/rocsparse
branch
from
October 30, 2022 17:09
462e36d
to
bf680a4
Compare
Madouura
changed the title
rocsparse: init at 2.3.2-5.3.0
rocsparse: init at 2.3.2-5.3.1
Oct 30, 2022
Madouura
force-pushed
the
pr/rocsparse
branch
from
November 3, 2022 11:41
bf680a4
to
00f3e54
Compare
lovesegfault
reviewed
Nov 3, 2022
Madouura
force-pushed
the
pr/rocsparse
branch
from
November 3, 2022 18:22
00f3e54
to
7729ba9
Compare
Madouura
force-pushed
the
pr/rocsparse
branch
from
November 3, 2022 18:22
7729ba9
to
20d160d
Compare
Rolled into #198770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild
10.rebuild-linux: 0
This PR does not cause any packages to rebuild
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tracking: #197885
Third part in a whole bunch of porting...
rocsparse.passthru.tests
will likely always fail due to it being in a vm, but I have confirmeda subset of tests (there are like 284K of them...) generated do work on hardwareall tests work!.We may want to consider how many of these tests we want to do whenever it is possible to use GPU acceleration (emulated or real) in testing vms.
Depends on #197337
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes