Fix MDI forces structure #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loriab
reviewed
Aug 3, 2023
There was a problem hiding this comment.
Hi Taylor, everything looks good except for the GAMESS changes. The if "system__mwords" breaks one of the memory setting tests.
qcengine/programs/tests/test_canonical_config.py::test_local_options_memory_gib[gamess-model2-keywords2-none] PASSED [ 20%]
qcengine/programs/tests/test_canonical_config.py::test_local_options_memory_gib[gamess-model2-keywords2-dsl] FAILED [ 40%]
The ValueError addition is a little strange in that it's a Python error and not one of the qcng errors. Distributed error handling is convoluted (to me, at least), and with none of the other harnesses using this pattern plus MDI being in a class of its own in terms of how it runs things, I'm not sure how the ValueError fits in. Could you describe the circumstances in which these changes came about to help me understand them? Thanks!
loriab
approved these changes
Aug 8, 2023
| natoms : int, optional | ||
| New number of atoms. If None, receive through MDI. | ||
| """ | ||
| natom = len(self.molecule.geometry) |
Check notice
Code scanning / CodeQL
Unused local variable Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a simple fix to ensure that the MDI interface properly formats the forces prior to communication.
Changelog description
Fix bug in the shape of the MDI forces structure
Status