gamess memory changes #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| mwords, memddi = self._partition(mwords_total, mem_frac_replicated, config.ncores) | ||
| # DEBUG print(f"loop {mwords_total=} {mem_frac_replicated=} {config.ncores=} -> repl: {mwords=} dist: {memddi=} -> percore={memddi/config.ncores + mwords} tot={memddi + config.ncores * mwords}\n") | ||
| trial_opts = copy.deepcopy(opts) | ||
| trial_opts["contrl__exetyp"] = "check" |
Check failure
Code scanning / CodeQL
Modification of parameter with default Error
| # DEBUG print(f"loop {mwords_total=} {mem_frac_replicated=} {config.ncores=} -> repl: {mwords=} dist: {memddi=} -> percore={memddi/config.ncores + mwords} tot={memddi + config.ncores * mwords}\n") | ||
| trial_opts = copy.deepcopy(opts) | ||
| trial_opts["contrl__exetyp"] = "check" | ||
| trial_opts["system__parall"] = not (config.ncores == 1) |
Check failure
Code scanning / CodeQL
Modification of parameter with default Error
| trial_opts = copy.deepcopy(opts) | ||
| trial_opts["contrl__exetyp"] = "check" | ||
| trial_opts["system__parall"] = not (config.ncores == 1) | ||
| trial_opts["system__mwords"] = mwords |
Check failure
Code scanning / CodeQL
Modification of parameter with default Error
| trial_opts["contrl__exetyp"] = "check" | ||
| trial_opts["system__parall"] = not (config.ncores == 1) | ||
| trial_opts["system__mwords"] = mwords | ||
| trial_opts["system__memddi"] = memddi |
Check failure
Code scanning / CodeQL
Modification of parameter with default Error
| elif "EXECUTION OF GAMESS TERMINATED -ABNORMALLY-" in dexe["stdout"]: | ||
| pass | ||
| else: | ||
| opts["system__mwords"] = mwords |
Check failure
Code scanning / CodeQL
Modification of parameter with default Error
| pass | ||
| else: | ||
| opts["system__mwords"] = mwords | ||
| opts["system__memddi"] = memddi |
Check failure
Code scanning / CodeQL
Modification of parameter with default Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was originally proposed in #401 but there was some trouble #401 (review) so separated out. Taylor reports that the
system__mwordschange needed to run GAMESS on Perlmutter.Changelog description
Status