Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defer MPI in MDI #420

Closed
wants to merge 1 commit into from
Closed

defer MPI in MDI #420

wants to merge 1 commit into from

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Aug 8, 2023

Description

This addresses #399. If one has pymdi and mpi4py packages in the environment, then merely import qcengine adds a bunch of potentially interfering mpi envvars. The culprit in particular is from mpi4py import MPI.

This PR solves #399 by deferring import of mpi4py until the MDIServer is created. But (1) I don't know if that interferes with MDI, hence the @taylor-a-barnes ping (though he's out of the office for a while). Also (2) since MDI isn't a harness like all other programs or procedures, its code is more exposed and can't really be hidden behind execute(). Thus, the problem is still present if MDI has ever been invoked, and qcengine can still interfere with other, potentially non-qcng-controlled processes. Probably there should at least be a toggle to turn off MDI MPI even if mpi4py is present.

Changelog description

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #420 (f7bf8c1) into master (034fd1a) will decrease coverage by 18.24%.
The diff coverage is 50.00%.

Additional details and impacted files

@loriab
Copy link
Collaborator Author

loriab commented Aug 8, 2023

aha, the mpi4py is already gone in #401, so that fixes #399 nicely.

@loriab
Copy link
Collaborator Author

loriab commented Aug 8, 2023

rendered unnecessary by #401

@loriab loriab closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant