Backports for 1.9.0-rc1 #48733
Merged
Backports for 1.9.0-rc1 #48733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users tried to pass a `dlopen()` handle into `lbt_forward()` which sadly works just fine, despite `ccall()` declaring its first argument as being a `Cstring`. I guess it's trivial to convert a `Ptr{Cvoid}` into a `Cstring`, so this just goes through.
To protect against this, restrict `path` to be an `AbstractString`.
(cherry picked from commit 8492031)
(cherry picked from commit 43c6f75)
(cherry picked from commit ecfaef3)
) (cherry picked from commit aaab409)
(cherry picked from commit 9c4a40c)
KristofferC
force-pushed
the
backports-release-1.9
branch
4 times, most recently
from
7a8b438
to
aa1d668
Compare
I found some lattice issues when implementing `MustAlias` under the new extendable lattice system in another PR. (cherry picked from commit ee0f3fc)
KristofferC
force-pushed
the
backports-release-1.9
branch
from
aa1d668
to
6ded08d
Compare
We used to have this hack before #48246, but I removed it because I had hoped we don't need. Unfortunately, we weren't able to infer consistency of ``` @inbounds (1,2)[1] ``` With this hack, constprop is able to independently prove inbounded-ness, overriding the usual consistency taintaing that happens for inbounds. (cherry picked from commit 113c2f3)
(cherry picked from commit 2a0b9dd)
(cherry picked from commit 6bd658e)
(cherry picked from commit 4a75129)
Many of these test were hiding output or using semi-deprecated functions or failing to cleanup output or setting the wrong variables. (cherry picked from commit b48104d)
* effects: taint `:nothrow` effect on unknown `:static_parameter` (conservatively)
With this commit, we taint `:nothrow` effect property correctly on
access to unknown `:static_parameter`, e.g.:
```julia
unknown_sparam_throw(::Union{Nothing, Type{T}}) where T = (T; nothing)
@test Core.Compiler.is_nothrow(Base.infer_effects(unknown_sparam_throw, ((Type{Int},))))
@test !Core.Compiler.is_nothrow(Base.infer_effects(unknown_sparam_throw, ((Nothing,))))
```
This commit implements a very conservative analysis, and thus there is a
room for improvement still, e.g.:
```julia
unknown_sparam_nothrow(x::Ref{T}) where {T} = (T; nothing)
@test_broken Core.Compiler.is_nothrow(Base.infer_effects(unknown_sparam_nothrow, (Ref,)))
```
* inference: improve `:nothrow` modeling for `:static_parameter` (#46820)
* Fix test with free type params
* Test: Ignore ::Type{T} in detect_unbounded
These are only technically unbounded because of the existence of
ill-formed types. However, this function is supposed to be an API
sanity check and ordinary users should never have ill-formed types,
so for the purpose we want here, allow unboundedness in Type{T}.
---------
Co-authored-by: Keno Fischer <[email protected]>
Co-authored-by: Elliot Saba <[email protected]>
(cherry picked from commit b5d17ea)
(cherry picked from commit c0d2c57)
* Run dsymutil on pkgimgs for apple platforms + LLD bump to get dsymutil from the jll (cherry picked from commit d8c2250)
(cherry picked from commit 56667bb)
* [OpenBLAS_jll] Upgrade to new build optimised for PowerPC This only difference compared to previous build is that this one enables use of dynamic architecture detection also for the PowerPC architecture. --------- Co-authored-by: Valentin Churavy <[email protected]> (cherry picked from commit aacfcf0)
On 64-bit, we have enough space to encode (1) the tag, (2) the `depmods` index, and (3) the offset all in a single 64-bit pointer field. This means we don't need the external `link_id` arrays, which reduces the size of many pkgimages by ~5%. On 32-bit, we don't have enough bits to implement this strategy. However, most linkages seem to be against the sysimage, and so by giving that a separate tag we can achieve similar compression because the `link_id` lists will be much shorter. Co-authored-by: Tim Holy <[email protected]> (cherry picked from commit 8e3e970)
(cherry picked from commit 0975906)
KristofferC
force-pushed
the
backports-release-1.9
branch
from
f805a02
to
50b8c13
Compare
We need to make sure that libjulia-internal is loaded and placed first in the DynamicLibrary search order so that calls to runtime intrinsics are resolved to the correct library when multiple libjulia-*'s have been loaded (e.g. when we `ccall` into a PackageCompiler.jl-created shared library). (cherry picked from commit fd45943)
* Update MbedTLS to 2.28.2 * Update deps/mbedtls.mk * Update mbedtls checksum (cherry picked from commit 127fb73)
* Always use `-Wl,--warn-unresolved-symbols` in MSAN builds * Use `-Wl,--warn-unresolved-symbols` only on Linux and FreeBSD (cherry picked from commit a07f512)
(cherry picked from commit 48b4caa)
Co-authored-by: Jameson Nash <[email protected]> Co-authored-by: Dilum Aluthge <[email protected]> (cherry picked from commit 6412a56)
* enable using external code in pkgimages This was unintentionally disabled (and incomplete) in the original PR for pkgimages. Co-authored-by: Valentin Churavy <[email protected]> (cherry picked from commit c136b7e)
(cherry picked from commit 7e57dc7)
Memoizing this can save a lot of repeated effort for queries such as `@which eltype(String)`. Otherwise we repeatedly try to check if `eltype(::Type)` is a good way to cache that result, even though it never gets better the more we check it. (cherry picked from commit bdcd5e2)
KristofferC
force-pushed
the
backports-release-1.9
branch
from
d5651bc
to
b07fb40
Compare
There is actually almost no cases where `jl_alloc_svec_uninit` is safe, since if was safe, you would likely would prefer to use the `jl_svec` constructor instead. (cherry picked from commit 0608824)
188m for this testset is exceeding our timeout on master this takes |
vchuravy
reviewed
Mar 6, 2023
(cherry picked from commit 3850e88)
This ensures that the value gets set after all possible compilation has occurred. (cherry picked from commit 0ec704e)
(cherry picked from commit 39e34ee)
* Fix sorting missing values with offset indices * Add tests (cherry picked from commit 7eb9615)
* Fix heapsize hint and use a line so that large machines utilize more of their ram (cherry picked from commit 51db8af)
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
pathto be anAbstractStringinlbt_forward()#48567GotoIfNotcan throw #48583insert_extension_triggersidempotent #48586:nothroweffect on unknown:static_parameter#46791nonoverlayedwhen bailing out inference #48838:inaccessiblememonly#48854PATCHELF_SET_RPATH_ARG#48788libjulia-internalto ORCJIT symbol resolution #48712-Wl,--warn-unresolved-symbolsin MSAN builds #48835:inaccessiblememonly#48854Non-merged PRs with backport label:
enq_workbehavior when single-threaded #48702--heap-size-hintarg handling #48050