[compiler] Teach type inference that GotoIfNot can throw
#48583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
force-pushed
the
sf/gotoifnot_throw
branch
from
91080e2
to
adee936
Compare
Previously, the effects system would ignore certain cases where
`GotoIfNot` nodes would be capable of throwing; this resulted in simple
examples such as the following being marked as `nothrow`:
```
julia> foo(x) = x > 0 ? x : 0
Base.infer_effects(foo, (Missing,))
(+c,+e,+n,+t,+s,+m,+i)
```
With this change, we correctly notice when a `GotoIfNot` node is given a
non-`Bool` condition, annotate the basic block as possibly throwing, and
further end type inference if the condition is provably non-`Bool`.
staticfloat
force-pushed
the
sf/gotoifnot_throw
branch
from
adee936
to
43235e9
Compare
vtjnash
approved these changes
Feb 7, 2023
|
Labeled as backport under the assumption that this is an effect bugfix for 1.9 as well. |
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2023
Previously, the effects system would ignore certain cases where
`GotoIfNot` nodes would be capable of throwing; this resulted in simple
examples such as the following being marked as `nothrow`:
```
julia> foo(x) = x > 0 ? x : 0
Base.infer_effects(foo, (Missing,))
(+c,+e,+n,+t,+s,+m,+i)
```
With this change, we correctly notice when a `GotoIfNot` node is given a
non-`Bool` condition, annotate the basic block as possibly throwing, and
further end type inference if the condition is provably non-`Bool`.
(cherry picked from commit 68ada71)
|
This causes a regression on 1.9 when backported in that |
|
does this also affect 1.10? |
|
It's in CI so 1.10 seems to be fine. I noticed on 1.9 due to test failure: Lines 481 to 482 in 6523b0c |
aviatesk
pushed a commit
that referenced
this pull request
Feb 22, 2023
Previously, the effects system would ignore certain cases where
`GotoIfNot` nodes would be capable of throwing; this resulted in simple
examples such as the following being marked as `nothrow`:
```
julia> foo(x) = x > 0 ? x : 0
Base.infer_effects(foo, (Missing,))
(+c,+e,+n,+t,+s,+m,+i)
```
With this change, we correctly notice when a `GotoIfNot` node is given a
non-`Bool` condition, annotate the basic block as possibly throwing, and
further end type inference if the condition is provably non-`Bool`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the effects system would ignore certain cases where
GotoIfNotnodes would be capable of throwing; this resulted in simple examples such as the following being marked asnothrow:With this change, we correctly notice when a
GotoIfNotnode is given a non-Boolcondition, annotate the basic block as possibly throwing, and further end type inference if the condition is provably non-Bool.