Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump LLD to get dsymutil and run it through the pkgimgs #48628

Merged
merged 5 commits into from
Feb 11, 2023

Conversation

gbaraldi
Copy link
Member

Finishes fixing #48020

LLD bump to get dsymutil from the jll
@KristofferC KristofferC added the backport 1.9 Change should be backported to release-1.9 label Feb 10, 2023
@vchuravy
Copy link
Sponsor Member

I am afk right now, but for the LRU cache of cachefiles we count the number of files in the directory (and also rn then accordingly) you will need to add dsym there

@gbaraldi
Copy link
Member Author

Where do we manage it? In Pkg itself or is it in julia?

@vchuravy
Copy link
Sponsor Member

Looks like I did the filtering on .ji already, but you will have to delete the dsym here

rm(ocachefile_from_cachefile(evicted_cachefile); force=true)

base/loading.jl Outdated Show resolved Hide resolved
@vchuravy vchuravy merged commit d8c2250 into JuliaLang:master Feb 11, 2023
@vchuravy vchuravy added system:mac Affects only macOS pkgimage labels Feb 11, 2023
@KristofferC KristofferC mentioned this pull request Feb 20, 2023
50 tasks
KristofferC pushed a commit that referenced this pull request Feb 20, 2023
* Run dsymutil on pkgimgs for apple platforms +
LLD bump to get dsymutil from the jll

(cherry picked from commit d8c2250)
KristofferC pushed a commit that referenced this pull request Feb 20, 2023
* Run dsymutil on pkgimgs for apple platforms +
LLD bump to get dsymutil from the jll

(cherry picked from commit d8c2250)
KristofferC pushed a commit that referenced this pull request Feb 21, 2023
* Run dsymutil on pkgimgs for apple platforms +
LLD bump to get dsymutil from the jll

(cherry picked from commit d8c2250)
KristofferC pushed a commit that referenced this pull request Feb 21, 2023
* Run dsymutil on pkgimgs for apple platforms +
LLD bump to get dsymutil from the jll

(cherry picked from commit d8c2250)
KristofferC pushed a commit that referenced this pull request Feb 21, 2023
* Run dsymutil on pkgimgs for apple platforms +
LLD bump to get dsymutil from the jll

(cherry picked from commit d8c2250)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkgimage system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants