Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 1.8-rc2/1.8.0 #45491

Merged
merged 40 commits into from
Jul 6, 2022
Merged

Backports for 1.8-rc2/1.8.0 #45491

merged 40 commits into from
Jul 6, 2022

Conversation

KristofferC
Copy link
Sponsor Member

@KristofferC KristofferC commented May 28, 2022

Backported PRs:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:

Keno and others added 8 commits May 28, 2022 08:24
We have `typeof(Union{}) == Type{Union{}}`, but were treating them
differently in the calculation of `isdispatchtuple`. The compiler
expects `isdispatchtuple` to commute with type equality in various
places, so try to make this consistent.

Fixes #45347

(cherry picked from commit a37dd16)
This new build doesn't depend on Kerberos

Co-authored-by: Mosè Giordano <[email protected]>
(cherry picked from commit 28d9326)
@ufechner7
Copy link

JuliaLang/Pkg.jl#2990 should be included. This fixes a very annoying bug which is still present in 1.8.0-rc1

@KristofferC
Copy link
Sponsor Member Author

KristofferC commented Jun 2, 2022

Yep, thanks for the pointer.

@KristofferC
Copy link
Sponsor Member Author

Eh, that commit is already included from what I can see. So could you elaborate a bit on what the issue is?

@ufechner7
Copy link

ufechner7 commented Jun 2, 2022

See:
https://discourse.julialang.org/t/inconsistant-message-in-julia-1-8-rc1/82104

When running "test" in package manager I get the message:
"Info Packages marked with ⌃ and ⌅ have new versions available, but those with ⌅ cannot be upgraded. To see why use status --outdated", but if I run "status --outdated" nothing is shown...

Which is this bug: JuliaLang/Pkg.jl#2989 which is closed, but still present in 1.8.0-rc1

KristofferC and others added 7 commits June 7, 2022 16:03
* diagonal*offset matrix should throw

(cherry picked from commit 172bddc)
Since the `data` argument possibly does not come from the current
configuration, we should not use `nthreads` here either to filter out
possibly significant data.

(cherry picked from commit b46c14e)
@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(ALL, vs = ":release-1.8")

@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runbenchmarks(ALL, vs = ":release-1.8")

@nanosoldier
Copy link
Collaborator

Something went wrong when running your job:

NanosoldierError: error when preparing/pushing to report repo: failed process: Process(setenv(`git push`; dir="/nanosoldier/workdir/NanosoldierReports"), ProcessExited(1)) [1]

Unfortunately, the logs could not be uploaded.

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

…5615)

`is_foldable` should be more aligned with `Base.@assume_effects`.
This should be backported to 1.8 also.
@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(["AlphaStableDistributions", "AutomotiveVisualization", "Bonsai", "ConScape", "ControlSystemIdentification", "DASKR", "GeoArrays", "HighDimPDE", "InvertibleNetworks", "MKL", "OteraEngine", "OutlierDetectionData", "PNGFiles", "ParameterEstimateScatterPlots", "Reactive", "SeisNoise", "ShipMMG"], vs = ":release-1.8")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

LebedevRI and others added 2 commits June 14, 2022 13:19
I've omitted `invpcid` feature since it's clearly omitted for other CPU's.

Fixes #45657

(cherry picked from commit 3f047f7)
@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(ALL, vs = ":release-1.8", buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"], vs_buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"])

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(["AlphaStableDistributions", "ApproxFunOrthogonalPolynomials", "AugmentedGaussianProcesses", "BifurcationInference", "Cambrian", "EclipsingBinaryStars", "ElasticArrays", "EnsembleKalmanProcesses", "FHIRClient", "FieldTracer", "GibbsSeaWater", "GitCommand", "Hashpipe", "HorseML", "InferOpt", "InformationGeometry", "MCPhyloTree", "MIToS", "MPSKit", "MemPool", "MultivariatePolynomials", "NNlib", "NavAbilitySDK", "NormalSplines", "PhaseSpaceTools", "PotentialFlow", "ProgressiveHedging", "Quiqbox", "RetroCap", "SpinDoctor", "SummationByPartsOperators"], vs = ":release-1.8")

@KristofferC
Copy link
Sponsor Member Author

Should have been run with assertions:

@nanosoldier runtests(["AlphaStableDistributions", "ApproxFunOrthogonalPolynomials", "AugmentedGaussianProcesses", "BifurcationInference", "Cambrian", "EclipsingBinaryStars", "ElasticArrays", "EnsembleKalmanProcesses", "FHIRClient", "FieldTracer", "GibbsSeaWater", "GitCommand", "Hashpipe", "HorseML", "InferOpt", "InformationGeometry", "MCPhyloTree", "MIToS", "MPSKit", "MemPool", "MultivariatePolynomials", "NNlib", "NavAbilitySDK", "NormalSplines", "PhaseSpaceTools", "PotentialFlow", "ProgressiveHedging", "Quiqbox", "RetroCap", "SpinDoctor", "SummationByPartsOperators"], vs = ":release-1.8", buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"], vs_buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"])

vchuravy and others added 20 commits July 4, 2022 17:02
This fixes hundreds of invalidations from Unitful.

Co-authored by: Shuhei Kadowaki <[email protected]>
`@time` now shows if any of the compilation time was spent recompiling invalidated methods. The new percentage is % of the compilation time, not the total execution time.

(cherry picked from commit 7074f04)
This is theoretically okay, but unlikely to be intended ever.

(cherry picked from commit d81724a)
Does not explicitly close issue #45704, as perhaps the deserialized
module should still be valid after the replacement warning.

(cherry picked from commit ad8893b)
Ensures we do not get easily wedged into bad states.

(cherry picked from commit d0e28af)
Regressions introduced by #45607

(cherry picked from commit 239a1f2)
fix #44705

(cherry picked from commit 4115686)
…ation (#45746)

* Bump LBT to 5.1.1
* Use DESTDIR to install into
* Update LBT checksums

(cherry picked from commit 1d78265)
(cherry picked from commit 1f99ee9)
When egal objects contain identical typevars with different
environments, the resulting subtyping might not be so obvious.

Fix #45703

(cherry picked from commit 8ccf2d6)
This prevents a compiler warning on some systems

(cherry picked from commit 05eb153)
@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

* Bug fix for `max_collect_interval` computation (#45727)

Currently constrained to `totalmem / ncores / 2` for `_P64` which
results in a very short collect interval when you're running with
a smaller number of threads on a machine with many cores.

Changes this to `totalmem / nthreads / 2` which, for two of our
tests, resulted in 40% and 60% runtime reduction (!!) as well as
GC time reduction from 46% to 10% and 64% to 11%.

* Move GC init after threading init

To allow use of `jl_n_threads` in GC initialization.
@KristofferC KristofferC merged commit 381eac3 into release-1.8 Jul 6, 2022
@KristofferC KristofferC deleted the backports-release-1.8 branch July 6, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet