Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 1.8-rc2/1.8.0 #45491

Merged
merged 40 commits into from
Jul 6, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
63e5553
Make `isdispatchtuple` consistent for `typeof(Union{})` (#45348)
Keno May 22, 2022
25122e4
Do not set MCPU on Apple Silicon (#45409)
fxcoudert May 21, 2022
0769bb5
Update LibCURL to 7.83.1 (#45443)
fxcoudert May 29, 2022
bde7223
Revert "fix #45440, improve the robustness of concrete-evaled callsit…
aviatesk May 30, 2022
801458d
follow #45440, add assertion to check concrete-eval call is compileable
aviatesk May 27, 2022
8f1a4ce
tweak NEWS.md
aviatesk May 31, 2022
32106ab
note `@inline` inside body usage (#45531)
Moelf Jun 1, 2022
4c65dce
rename `Base.@assume_effects :total_may_throw` setting to `:foldable`…
aviatesk Jun 1, 2022
ba72387
also set the version in `pkgorigins` (#44318)
KristofferC Feb 24, 2022
9e17fb6
Make llvmunwind depend on llvm (#45380)
fxcoudert May 29, 2022
b6e47d4
csl.mk: use libgcc_s 1.1 on aarch64-darwin (#45504)
fxcoudert May 29, 2022
d6bbed6
Fix zero-length array concatenation validation (#45383)
BioTurboNick Jun 1, 2022
a004142
Fix segfault in `Diagonal` * `OffsetMatrix` (#45548)
jishnub Jun 2, 2022
6f0bfc2
bump Pkg version to latest 1.8
Jun 8, 2022
087ba27
[Profile] `threads` here is wrong to use `nthreads` (#45547)
vtjnash Jun 2, 2022
43df1f4
rename `is_concrete_eval_eligible` utility query to `is_foldable` (#4…
aviatesk Jun 9, 2022
3a2eb39
Revert "codegen: explicitly handle Float16 intrinsics (#45249)" (#45627)
KristofferC Jun 13, 2022
8fd0b2a
AMD Zen 3 CPU support (Fixes #45657) (#45663) (#45667)
LebedevRI Jun 14, 2022
8b2e406
update `@assume_effects`
aviatesk Jun 15, 2022
38b836a
Update LLVM to 13.0.1+1
vchuravy Jun 19, 2022
4acdabe
fixup! Update LLVM to 13.0.1+1
vchuravy Jun 20, 2022
853dff9
fixup! fixup! Update LLVM to 13.0.1+1
vchuravy Jun 20, 2022
67f365c
Improve inference in typejoin (#44390)
timholy Mar 3, 2022
f83a9b3
[1.8] Update LLVM to 13.0.2-2 (#45917)
vchuravy Jul 4, 2022
b97d34a
Report any recompilation in time macro (#45015)
IanButterworth Apr 20, 2022
ad61d03
Add compilation & recompilation time to time_imports macro (#45064)
IanButterworth Apr 28, 2022
0646ce7
loading: prevent module replacement during precompile
vtjnash Jun 30, 2022
89cb6df
loading: add missing deadlock causing #45704
vtjnash Jun 29, 2022
73b37b2
loading: validate all cache files before loading any
vtjnash Jun 29, 2022
0ce21a6
loading: stop corrupting memory all over the place
vtjnash Jun 29, 2022
11cfa4e
Fix llvm powi intrinsic calls in fastmath.jl (#44580)
pchintalapudi Mar 12, 2022
8fcc2dd
fix `tuple_tfunc` on `Union` containing `Type{...}` (#44725)
aviatesk Mar 30, 2022
97c17e0
inference: don't widen `DataType`/`UninAll` to `Type` within `tuple_t…
aviatesk Apr 11, 2022
fbae62d
Pass along backlog keyword argument in Sockets.listen (#45737)
quinnj Jun 19, 2022
0559fa6
Use https for downloading of unicode data from unicode.org (#45750)
ViralBShah Jun 19, 2022
929c48a
Fix libblastrampoline full source build to install into the right loc…
ViralBShah Jun 19, 2022
14be137
Document file descriptors in `run` (#45710)
oscardssmith Jun 21, 2022
5894899
fix obvious_subtype bug with egal objects (#45771)
JeffBezanson Jun 27, 2022
2b6c746
Remove duplicate definition of jl_gc_safepoint (#45120)
fingolfin Jul 1, 2022
7a23871
Backport #45727 and a patch to make it work (#45938)
kpamnany Jul 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix zero-length array concatenation validation (#45383)
(cherry picked from commit 0a55a8e)
  • Loading branch information
BioTurboNick authored and KristofferC committed Jun 7, 2022
commit d6bbed63bd37cdfac2d48ba5f9a60a298d6e0940
4 changes: 2 additions & 2 deletions base/abstractarray.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2478,7 +2478,7 @@ function _typed_hvncat_shape(::Type{T}, shape::NTuple{N, Tuple}, row_first, as::
shapelength == lengthas || throw(ArgumentError("number of elements does not match shape; expected $(shapelength), got $lengthas)"))
# discover dimensions
nd = max(N, cat_ndims(as[1]))
outdims = zeros(Int, nd)
outdims = fill(-1, nd)
currentdims = zeros(Int, nd)
blockcounts = zeros(Int, nd)
shapepos = ones(Int, nd)
Expand All @@ -2503,7 +2503,7 @@ function _typed_hvncat_shape(::Type{T}, shape::NTuple{N, Tuple}, row_first, as::

isendblock = blockcounts[d] == shapev[d][shapepos[d]]
if isendblock
if outdims[d] == 0
if outdims[d] == -1
outdims[d] = currentdims[d]
elseif outdims[d] != currentdims[d]
throw(ArgumentError("argument $i has a mismatched number of elements along axis $ad; \
Expand Down
4 changes: 1 addition & 3 deletions test/abstractarray.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1465,9 +1465,7 @@ using Base: typed_hvncat
v1 = zeros(Int, 0, 0, 0)
for v2 ∈ (1, [1])
for v3 ∈ (2, [2])
# current behavior, not potentially dangerous.
# should throw error like above loop
@test [v1 ;;; v2 v3] == [v2 v3;;;]
@test_throws ArgumentError [v1 ;;; v2 v3]
@test_throws ArgumentError [v1 ;;; v2]
@test_throws ArgumentError [v1 v1 ;;; v2 v3]
end
Expand Down